Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: android_webview/renderer/aw_render_view_ext.cc

Issue 475633002: Pass TouchMajor to HitTestResult (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/renderer/aw_render_view_ext.cc
diff --git a/android_webview/renderer/aw_render_view_ext.cc b/android_webview/renderer/aw_render_view_ext.cc
index dc4264edc3db1129fb4cd3aec4512e7b9df6de61..f5f3e5fd3cc61060ba4bc54d8a9af91876dedc88 100644
--- a/android_webview/renderer/aw_render_view_ext.cc
+++ b/android_webview/renderer/aw_render_view_ext.cc
@@ -265,13 +265,14 @@ void AwRenderViewExt::FocusedNodeChanged(const blink::WebNode& node) {
Send(new AwViewHostMsg_UpdateHitTestData(routing_id(), data));
}
-void AwRenderViewExt::OnDoHitTest(int view_x, int view_y) {
+void AwRenderViewExt::OnDoHitTest(gfx::RectF touch_area) {
if (!render_view() || !render_view()->GetWebView())
return;
const blink::WebHitTestResult result =
- render_view()->GetWebView()->hitTestResultAt(
- blink::WebPoint(view_x, view_y));
+ render_view()->GetWebView()->hitTestResultForTap(
+ blink::WebPoint(touch_area.x(), touch_area.y()),
jdduke (slow) 2014/10/30 19:54:58 Ugg, this is misleading. The x/y coordinate of you
hush (inactive) 2014/11/04 01:55:57 Yes, misleading. I will pass the point and padding
+ gfx::Size(touch_area.width(), touch_area.height()));
AwHitTestData data;
if (!result.urlElement().isNull()) {
« android_webview/native/aw_contents.cc ('K') | « android_webview/renderer/aw_render_view_ext.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698