Pass TouchMajor to HitTestResult

android_webview/renderer/aw_render_view_ext.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/renderer/aw_render_view_ext.h"
 
 #include <string>
 
 #include "android_webview/common/aw_hit_test_data.h"
 #include "android_webview/common/render_view_messages.h"
@@ skipping 247 matching lines @@
         GetAbsoluteSrcUrl(child_img);
   }
 
   PopulateHitTestData(absolute_link_url,
                       absolute_image_url,
                       render_view()->IsEditableNode(node),
                       &data);
   Send(new AwViewHostMsg_UpdateHitTestData(routing_id(), data));
 }
 
-void AwRenderViewExt::OnDoHitTest(int view_x, int view_y) {
+void AwRenderViewExt::OnDoHitTest(gfx::RectF touch_area) {
   if (!render_view() || !render_view()->GetWebView())
     return;
 
   const blink::WebHitTestResult result =
-      render_view()->GetWebView()->hitTestResultAt(
-          blink::WebPoint(view_x, view_y));
+      render_view()->GetWebView()->hitTestResultForTap(
+          blink::WebPoint(touch_area.x(), touch_area.y()),

[jdduke (slow), 2014/10/30 19:54:58]

Ugg, this is misleading. The x/y coordinate of your box are at the top left of
the box, but Blink expects the center coordinate. Please just mirror the Blink
API to prevent any confusion (i.e., use a center point gfx::PointF, and a size,
gfx::SizeF).

[hush (inactive), 2014/11/04 01:55:57]

Yes, misleading. I will pass the point and padding separately.

+          gfx::Size(touch_area.width(), touch_area.height()));
   AwHitTestData data;
 
   if (!result.urlElement().isNull()) {
     data.anchor_text = result.urlElement().innerText();
     data.href = GetHref(result.urlElement());
   }
 
   PopulateHitTestData(result.absoluteLinkURL(),
                       result.absoluteImageURL(),
                       result.isContentEditable(),
@@ skipping 22 matching lines @@
       page_scale_factor);
 }
 
 void AwRenderViewExt::OnSetBackgroundColor(SkColor c) {
   if (!render_view() || !render_view()->GetWebView())
     return;
   render_view()->GetWebView()->setBaseBackgroundColor(c);
 }
 
 }  // namespace android_webview