Pass TouchMajor to HitTestResult

android_webview/native/aw_contents.cc

Index: android_webview/native/aw_contents.cc
diff --git a/android_webview/native/aw_contents.cc b/android_webview/native/aw_contents.cc
index 4bd68b78f36e9b75adc375c53483e595963252bf..fce7f054340a492cb5a8feae1ef5af651dd0ea58 100644
--- a/android_webview/native/aw_contents.cc
+++ b/android_webview/native/aw_contents.cc
@@ -64,6 +64,7 @@
 #include "net/cert/x509_certificate.h"
 #include "third_party/skia/include/core/SkPicture.h"
 #include "ui/gfx/android/java_bitmap.h"
+#include "ui/gfx/geometry/rect_f.h"
 #include "ui/gfx/image/image.h"
 #include "ui/gfx/size.h"
 
@@ -808,10 +809,15 @@ base::android::ScopedJavaLocalRef<jbyteArray>
       reinterpret_cast<const uint8*>(der_string.data()), der_string.length());
 }
 
-void AwContents::RequestNewHitTestDataAt(JNIEnv* env, jobject obj,
-                                         jint x, jint y) {
+void AwContents::RequestNewHitTestDataAt(JNIEnv* env,
+                                         jobject obj,
+                                         jint x,
+                                         jint y,
+                                         jfloat touch_major,
+                                         jfloat touch_minor) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
-  render_view_host_ext_->RequestNewHitTestDataAt(x, y);
+  gfx::RectF touch_area(x, y, touch_major / 2, touch_minor / 2);

[jdduke (slow), 2014/10/30 19:54:58]

x/y here correspond to the *center* of the rect, but you supply them as the rect
origin. Also, touch_major *is* the size of the area, so I'm still unsure why
you're dividing it in half...

[hush (inactive), 2014/11/04 01:55:57]

I agree this is weird. (you mentioned this in a comment in AwRenderViewExt as
well). I will pass the center point and the padding separately in the next
patch.
The "padding" parameter of the function EventHandler::hitTestResultAtPoint is
not the width and height of the touch area, it is half of that.
I sort of guessed it by looking at these 2 places:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
and:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

So padding.width() and padding.height() is how far the center point is from the
left/right and top/bottom.

Rick, please correct me if I said it wrong.

[hush (inactive), 2014/11/04 02:50:47]

Sorry. Scratch that.
Blink does the half resize for us in this case.
https://codereview.chromium.org/470833002/diff/40001/Source/core/page/EventHa...

+  render_view_host_ext_->RequestNewHitTestDataAt(touch_area);
 }
 
 void AwContents::UpdateLastHitTestData(JNIEnv* env, jobject obj) {