Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 47563006: Revert 232802 "[Net] Assert that URLRequests with LOAD_IGNORE_LI..." (Closed)

Created:
7 years, 1 month ago by scherkus (not reviewing)
Modified:
7 years, 1 month ago
Reviewers:
akalin
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 232802 "[Net] Assert that URLRequests with LOAD_IGNORE_LI..." > [Net] Assert that URLRequests with LOAD_IGNORE_LIMITS have MAXIMUM_PRIORITY > > Also remove the priority juggling in ClientSocketPoolBaseHelper, and instead > assert that any requests with ignore_limits = true also has priority = > MAXIMUM_PRIORITY. > > BUG=166689 > R=asanka@chromium.org, gene@chromium.org, joaodasilva@chromium.org, mmenke@chromium.org, simonjam@chromium.org > TBR=benm@chromium.org, jamesr@chromium.org > > Review URL: https://codereview.chromium.org/51683002 Broke PrerenderBrowserTest.PrerenderDeferredSynchronousXHR. Running locally I was hitting a check on url_request.cc:979. TBR=akalin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232832

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+318 lines, -292 lines) Patch
M trunk/src/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/net/chrome_fraudulent_certificate_reporter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/net/http_pipelining_compatibility_client.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/policy/url_blacklist_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/cloud_print/service/service_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/download/download_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/loader/resource_dispatcher_host_impl.cc View 5 chunks +4 lines, -13 lines 0 comments Download
M trunk/src/content/browser/loader/resource_scheduler.cc View 2 chunks +1 line, -8 lines 0 comments Download
M trunk/src/net/ocsp/nss_ocsp.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/proxy/proxy_script_fetcher_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/socket/client_socket_pool_base.cc View 3 chunks +9 lines, -16 lines 0 comments Download
M trunk/src/net/socket/client_socket_pool_base_unittest.cc View 111 chunks +268 lines, -165 lines 0 comments Download
M trunk/src/net/url_request/url_fetcher_core.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/url_request/url_request.h View 3 chunks +4 lines, -11 lines 0 comments Download
M trunk/src/net/url_request/url_request.cc View 2 chunks +0 lines, -22 lines 0 comments Download
M trunk/src/net/url_request/url_request_ftp_job.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/src/net/url_request/url_request_throttler_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/net/url_request/url_request_unittest.cc View 6 chunks +5 lines, -30 lines 0 comments Download
M trunk/src/webkit/browser/appcache/appcache_update_job.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scherkus (not reviewing)
7 years, 1 month ago (2013-11-04 23:25:29 UTC) #1
scherkus (not reviewing)
7 years, 1 month ago (2013-11-04 23:26:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r232832 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698