Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: trunk/src/net/url_request/url_request.h

Issue 47563006: Revert 232802 "[Net] Assert that URLRequests with LOAD_IGNORE_LI..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/net/url_request/url_fetcher_core.cc ('k') | trunk/src/net/url_request/url_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/net/url_request/url_request.h
===================================================================
--- trunk/src/net/url_request/url_request.h (revision 232831)
+++ trunk/src/net/url_request/url_request.h (working copy)
@@ -550,12 +550,8 @@
// Access the LOAD_* flags modifying this request (see load_flags.h).
int load_flags() const { return load_flags_; }
+ void set_load_flags(int flags) { load_flags_ = flags; }
- // The new flags may change the IGNORE_LIMITS flag only when called
- // before Start() is called, it must only set the flag, and if set,
- // the priority of this request must already be MAXIMUM_PRIORITY.
- void SetLoadFlags(int flags);
-
// Returns true if the request is "pending" (i.e., if Start() has been called,
// and the response has not yet been called).
bool is_pending() const { return is_pending_; }
@@ -655,9 +651,7 @@
// Returns the priority level for this request.
RequestPriority priority() const { return priority_; }
- // Sets the priority level for this request and any related
- // jobs. Must not change the priority to anything other than
- // MAXIMUM_PRIORITY if the IGNORE_LIMITS load flag is set.
+ // Sets the priority level for this request and any related jobs.
void SetPriority(RequestPriority priority);
// Returns true iff this request would be internally redirected to HTTPS
@@ -833,9 +827,8 @@
// first transaction in a request involving redirects.
UploadProgress final_upload_progress_;
- // The priority level for this request. Objects like
- // ClientSocketPool use this to determine which URLRequest to
- // allocate sockets to first.
+ // The priority level for this request. Objects like ClientSocketPool use
+ // this to determine which URLRequest to allocate sockets to first.
RequestPriority priority_;
// TODO(battre): The only consumer of the identifier_ is currently the
« no previous file with comments | « trunk/src/net/url_request/url_fetcher_core.cc ('k') | trunk/src/net/url_request/url_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698