Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Side by Side Diff: trunk/src/net/proxy/proxy_script_fetcher_impl.cc

Issue 47563006: Revert 232802 "[Net] Assert that URLRequests with LOAD_IGNORE_LI..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « trunk/src/net/ocsp/nss_ocsp.cc ('k') | trunk/src/net/socket/client_socket_pool_base.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/proxy/proxy_script_fetcher_impl.h" 5 #include "net/proxy/proxy_script_fetcher_impl.h"
6 6
7 #include "base/compiler_specific.h" 7 #include "base/compiler_specific.h"
8 #include "base/i18n/icu_string_conversions.h" 8 #include "base/i18n/icu_string_conversions.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 140
141 // Make sure that the PAC script is downloaded using a direct connection, 141 // Make sure that the PAC script is downloaded using a direct connection,
142 // to avoid circular dependencies (fetching is a part of proxy resolution). 142 // to avoid circular dependencies (fetching is a part of proxy resolution).
143 // Also disable the use of the disk cache. The cache is disabled so that if 143 // Also disable the use of the disk cache. The cache is disabled so that if
144 // the user switches networks we don't potentially use the cached response 144 // the user switches networks we don't potentially use the cached response
145 // from old network when we should in fact be re-fetching on the new network. 145 // from old network when we should in fact be re-fetching on the new network.
146 // If the PAC script is hosted on an HTTPS server we bypass revocation 146 // If the PAC script is hosted on an HTTPS server we bypass revocation
147 // checking in order to avoid a circular dependency when attempting to fetch 147 // checking in order to avoid a circular dependency when attempting to fetch
148 // the OCSP response or CRL. We could make the revocation check go direct but 148 // the OCSP response or CRL. We could make the revocation check go direct but
149 // the proxy might be the only way to the outside world. 149 // the proxy might be the only way to the outside world.
150 cur_request_->SetLoadFlags(LOAD_BYPASS_PROXY | LOAD_DISABLE_CACHE | 150 cur_request_->set_load_flags(LOAD_BYPASS_PROXY | LOAD_DISABLE_CACHE |
151 LOAD_DISABLE_CERT_REVOCATION_CHECKING); 151 LOAD_DISABLE_CERT_REVOCATION_CHECKING);
152 152
153 // Save the caller's info for notification on completion. 153 // Save the caller's info for notification on completion.
154 callback_ = callback; 154 callback_ = callback;
155 result_text_ = text; 155 result_text_ = text;
156 156
157 bytes_read_so_far_.clear(); 157 bytes_read_so_far_.clear();
158 158
159 // Post a task to timeout this request if it takes too long. 159 // Post a task to timeout this request if it takes too long.
160 cur_request_id_ = ++next_id_; 160 cur_request_id_ = ++next_id_;
161 base::MessageLoop::current()->PostDelayedTask( 161 base::MessageLoop::current()->PostDelayedTask(
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
314 // is still applicable. 314 // is still applicable.
315 if (cur_request_id_ != id) 315 if (cur_request_id_ != id)
316 return; 316 return;
317 317
318 DCHECK(cur_request_.get()); 318 DCHECK(cur_request_.get());
319 result_code_ = ERR_TIMED_OUT; 319 result_code_ = ERR_TIMED_OUT;
320 cur_request_->Cancel(); 320 cur_request_->Cancel();
321 } 321 }
322 322
323 } // namespace net 323 } // namespace net
OLDNEW
« no previous file with comments | « trunk/src/net/ocsp/nss_ocsp.cc ('k') | trunk/src/net/socket/client_socket_pool_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698