Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 475533008: Revert of Rotate screen in response to accelerator or device orientation sensors. (Closed)

Created:
6 years, 4 months ago by Nico
Modified:
6 years, 4 months ago
Reviewers:
danakj, oshima, sadrul, flackr
CC:
chromium-reviews, jam
Project:
chromium
Visibility:
Public.

Description

Revert of Rotate screen in response to accelerator or device orientation sensors. (patchset #12 of https://codereview.chromium.org/431183003/) Reason for revert: Speculative, athena_unittests and ui_unittests started failing in this build:http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29/builds/2771 ==6568==ERROR: AddressSanitizer: heap-use-after-free on address 0x60700000ba10 at pc 0x00000167d52a bp 0x7fff95f266f0 sp 0x7fff95f266e8 READ of size 8 at 0x60700000ba10 thread T0 #0 0x167d529 in DeleteInternal base/memory/ref_counted.h:190:44 #1 0x167d529 in Destruct base/memory/ref_counted.h:153 #2 0x167d529 in Release base/memory/ref_counted.h:181 #3 0x167d529 in ~scoped_refptr base/memory/ref_counted.h:289 #4 0x167d529 in ~SystemUIImpl athena/system/system_ui_impl.cc:27 #5 0x167d529 in athena::(anonymous namespace)::SystemUIImpl::~SystemUIImpl() athena/system/system_ui_impl.cc:26 #6 0x167d257 in athena::SystemUI::Shutdown() athena/system/system_ui_impl.cc:49:3 #7 0x577fa6 in athena::ShutdownAthena() athena/main/athena_launcher.cc:92:3 #8 0x57645f in athena::test::AthenaTestHelper::TearDown() athena/test/athena_test_helper.cc:98:3 #9 0x575266 in athena::test::AthenaTestBase::TearDown() athena/test/athena_test_base.cc:53:3 #10 0x505bc8 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5 #11 0x506906 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #12 0x51cb85 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #13 0x51c176 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #14 0x51c176 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #15 0xac6fb4 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #16 0xac6fb4 in base::TestSuite::Run() base/test/test_suite.cc:227 #17 0xabe39d in Run base/callback.h:401:12 #18 0xabe39d in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:498 #19 0xabf0de in base::LaunchUnitTestsSerially(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:564:10 #20 0x4d7bba in main athena/test/athena_unittests.cc:51:10 #21 0x7fd394e3476c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 #22 0x4d795c in _start (/mnt/data/b/build/slave/Linux_Chromium_OS_ASan_LSan_Tests__3_/build/src/out/Release/athena_unittests+0x4d795c) 0x60700000ba10 is located 0 bytes inside of 72-byte region [0x60700000ba10,0x60700000ba58) freed by thread T0 here: #0 0x452fcb in operator delete(void*) (/mnt/data/b/build/slave/Linux_Chromium_OS_ASan_LSan_Tests__3_/build/src/out/Release/athena_unittests+0x452fcb) #1 0x168323d in DeleteInternal base/memory/ref_counted.h:190:44 #2 0x168323d in Destruct base/memory/ref_counted.h:153 #3 0x168323d in Release base/memory/ref_counted.h:181 #4 0x168323d in ~scoped_refptr base/memory/ref_counted.h:289 #5 0x168323d in athena::OrientationController::OrientationController(scoped_refptr\u003Cbase::TaskRunner>) athena/system/orientation_controller.cc:66 #6 0x167cfea in SystemUIImpl athena/system/system_ui_impl.cc:23:61 #7 0x167cfea in athena::SystemUI::Create(scoped_refptr\u003Cbase::TaskRunner>) athena/system/system_ui_impl.cc:42 #8 0x577db0 in athena::StartAthena(aura::Window*, athena::ActivityFactory*, athena::AppModelBuilder*) athena/main/athena_launcher.cc:73:3 #9 0x576159 in athena::test::AthenaTestHelper::SetUp(ui::ContextFactory*) athena/test/athena_test_helper.cc:90:3 #10 0x503eb1 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2418:12 #11 0x503eb1 in testing::Test::Run() testing/gtest/src/gtest.cc:2430 #12 0x505bc8 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5 #13 0x506906 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #14 0x51cb85 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #15 0x51c176 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #16 0x51c176 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #17 0xac6fb4 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #18 0xac6fb4 in base::TestSuite::Run() base/test/test_suite.cc:227 #19 0xabe39d in Run base/callback.h:401:12 #20 0xabe39d in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:498 #21 0xabf0de in base::LaunchUnitTestsSerially(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:564:10 #22 0x4d7bba in main athena/test/athena_unittests.cc:51:10 #23 0x7fd394e3476c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 previously allocated by thread T0 here: #0 0x452a8b in operator new(unsigned long) (/mnt/data/b/build/slave/Linux_Chromium_OS_ASan_LSan_Tests__3_/build/src/out/Release/athena_unittests+0x452a8b) #1 0x167cfb5 in SystemUIImpl athena/system/system_ui_impl.cc:23:61 #2 0x167cfb5 in athena::SystemUI::Create(scoped_refptr\u003Cbase::TaskRunner>) athena/system/system_ui_impl.cc:42 #3 0x577db0 in athena::StartAthena(aura::Window*, athena::ActivityFactory*, athena::AppModelBuilder*) athena/main/athena_launcher.cc:73:3 #4 0x576159 in athena::test::AthenaTestHelper::SetUp(ui::ContextFactory*) athena/test/athena_test_helper.cc:90:3 #5 0x503eb1 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2418:12 #6 0x503eb1 in testing::Test::Run() testing/gtest/src/gtest.cc:2430 #7 0x505bc8 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5 #8 0x506906 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #9 0x51cb85 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #10 0x51c176 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #11 0x51c176 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #12 0xac6fb4 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #13 0xac6fb4 in base::TestSuite::Run() base/test/test_suite.cc:227 #14 0xabe39d in Run base/callback.h:401:12 #15 0xabe39d in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:498 #16 0xabf0de in base::LaunchUnitTestsSerially(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:564:10 #17 0x4d7bba in main athena/test/athena_unittests.cc:51:10 #18 0x7fd394e3476c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 TBR=oshima NOTRY=true NOTREECHECKS=true Original issue's description: > Rotate screen in response to accelerator or device orientation sensors. > > BUG=385295 > TEST=Press Ctrl+Shift+F3, screen rotates. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290007 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290089

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -639 lines) Patch
M athena/athena.gyp View 3 chunks +0 lines, -8 lines 0 comments Download
M athena/main/athena_launcher.cc View 2 chunks +1 line, -4 lines 0 comments Download
M athena/screen/public/screen_manager.h View 2 chunks +0 lines, -6 lines 0 comments Download
M athena/screen/screen_accelerator_handler.cc View 5 chunks +0 lines, -24 lines 0 comments Download
M athena/screen/screen_manager_impl.cc View 3 chunks +0 lines, -16 lines 0 comments Download
D athena/system/device_socket_listener.h View 1 chunk +0 lines, -48 lines 0 comments Download
D athena/system/device_socket_listener.cc View 1 chunk +0 lines, -287 lines 0 comments Download
D athena/system/orientation_controller.h View 1 chunk +0 lines, -65 lines 0 comments Download
D athena/system/orientation_controller.cc View 1 chunk +0 lines, -143 lines 0 comments Download
M athena/system/public/system_ui.h View 1 chunk +1 line, -6 lines 0 comments Download
M athena/system/system_ui_impl.cc View 4 chunks +3 lines, -12 lines 0 comments Download
M ui/aura/test/test_screen.cc View 3 chunks +6 lines, -20 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Nico
Created Revert of Rotate screen in response to accelerator or device orientation sensors.
6 years, 4 months ago (2014-08-16 05:15:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/475533008/1
6 years, 4 months ago (2014-08-16 05:17:06 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-16 05:17:07 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-16 05:17:07 UTC) #4
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 4 months ago (2014-08-16 05:22:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/475533008/1
6 years, 4 months ago (2014-08-16 05:24:06 UTC) #6
Nico
The CQ bit was unchecked by thakis@chromium.org
6 years, 4 months ago (2014-08-16 05:27:33 UTC) #7
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 4 months ago (2014-08-16 05:28:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/475533008/1
6 years, 4 months ago (2014-08-16 05:30:01 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-16 05:31:57 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (1) as 290089

Powered by Google App Engine
This is Rietveld 408576698