Issue 473973002: rebaseline_server: show Pending Approval tab if viewing SKP expectations vs actuals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 473973002: rebaseline_server: show Pending Approval tab if viewing SKP expectations vs actuals (Closed)

Created:
6 years, 4 months ago by epoger

Modified:
6 years, 4 months ago

Reviewers:
stephana

CC:
reviews_skia.org, rmistry

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

rebaseline_server: show Pending Approval tab if viewing SKP expectations vs actuals BUG=skia:1918 NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/9f1ae465c89bb47f4cbf972bc946f661d6d50b4e

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -10 lines)			Patch
	M	gm/rebaseline_server/server.py	View		4 chunks	+27 lines, -3 lines	0 comments	Download
	M	gm/rebaseline_server/static/live-view.html	View		2 chunks	+4 lines, -7 lines	0 comments	Download

Total messages: 5 (0 generated)

stephana

On 2014/08/14 16:34:14, epoger wrote: > Stephan: PTAL at patchset 1 LGTM

6 years, 4 months ago (2014-08-14 16:45:14 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/473973002/1

6 years, 4 months ago (2014-08-14 16:55:31 UTC) #4

commit-bot: I haz the power

6 years, 4 months ago (2014-08-14 16:55:41 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (1) as 9f1ae465c89bb47f4cbf972bc946f661d6d50b4e