Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: gm/rebaseline_server/static/live-view.html

Issue 473973002: rebaseline_server: show Pending Approval tab if viewing SKP expectations vs actuals (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gm/rebaseline_server/server.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/rebaseline_server/static/live-view.html
diff --git a/gm/rebaseline_server/static/live-view.html b/gm/rebaseline_server/static/live-view.html
index 721ca2ea211507d210e106ea86ae2f8413bd85d3..0c94c2b36996c8bb273fb2f52d1d5774235bf759 100644
--- a/gm/rebaseline_server/static/live-view.html
+++ b/gm/rebaseline_server/static/live-view.html
@@ -41,12 +41,6 @@
which records are displayed.
</div>
- <div class="warning-div"
- ng-show="header[constants.KEY__HEADER__IS_EDITABLE] && header[constants.KEY__HEADER__IS_EXPORTED]">
- WARNING! These results are editable and exported, so any user
- who can connect to this server over the network can modify them.
- </div>
-
<div ng-show="header[constants.KEY__HEADER__TIME_UPDATED]">
setA: "{{header[constants.KEY__HEADER__SET_A_DESCRIPTIONS][constants.KEY__SET_DESCRIPTIONS__SECTION]}}"
within {{header[constants.KEY__HEADER__SET_A_DESCRIPTIONS][constants.KEY__SET_DESCRIPTIONS__DIR]}}
@@ -176,10 +170,13 @@
<!-- Submission UI that we only show in the Pending Approval tab. -->
<div ng-show="'Pending Approval' == viewingTab">
+ <div style="font-size:20px">
+ TODO(epoger): We don't yet support submitting new SKP expectations.
+ </div>
<div style="display:inline-block">
<button style="font-size:20px"
ng-click="submitApprovals(filteredImagePairs)"
- ng-disabled="submitPending || (filteredImagePairs.length == 0)">
+ ng-disabled="true || submitPending || (filteredImagePairs.length == 0)">
Update these {{filteredImagePairs.length}} expectations on the server
</button>
</div>
« no previous file with comments | « gm/rebaseline_server/server.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698