Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: gm/rebaseline_server/static/live-view.html

Issue 473973002: rebaseline_server: show Pending Approval tab if viewing SKP expectations vs actuals (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gm/rebaseline_server/server.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 2
3 <html ng-app="Loader" ng-controller="Loader.Controller"> 3 <html ng-app="Loader" ng-controller="Loader.Controller">
4 4
5 <head> 5 <head>
6 <title ng-bind="windowTitle"></title> 6 <title ng-bind="windowTitle"></title>
7 <script src="//ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></scr ipt> 7 <script src="//ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></scr ipt>
8 <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.2.20/angular.js "></script> 8 <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.2.20/angular.js "></script>
9 <script src="constants.js"></script> 9 <script src="constants.js"></script>
10 <script src="live-loader.js"></script> 10 <script src="live-loader.js"></script>
(...skipping 23 matching lines...) Expand all
34 <div ng-show="readyToDisplay"> 34 <div ng-show="readyToDisplay">
35 35
36 <div class="warning-div" 36 <div class="warning-div"
37 ng-show="urlSchemaVersionLoaded != constants.URL_VALUE__SCHEMA_VERSION_ _CURRENT"> 37 ng-show="urlSchemaVersionLoaded != constants.URL_VALUE__SCHEMA_VERSION_ _CURRENT">
38 WARNING! The URL you loaded used schema version {{urlSchemaVersionLoaded} }, rather than 38 WARNING! The URL you loaded used schema version {{urlSchemaVersionLoaded} }, rather than
39 the most recent version {{constants.URL_VALUE__SCHEMA_VERSION__CURRENT}}. It has been 39 the most recent version {{constants.URL_VALUE__SCHEMA_VERSION__CURRENT}}. It has been
40 converted to the most recent version on a best-effort basis; you may wish to double-check 40 converted to the most recent version on a best-effort basis; you may wish to double-check
41 which records are displayed. 41 which records are displayed.
42 </div> 42 </div>
43 43
44 <div class="warning-div"
45 ng-show="header[constants.KEY__HEADER__IS_EDITABLE] && header[constants .KEY__HEADER__IS_EXPORTED]">
46 WARNING! These results are editable and exported, so any user
47 who can connect to this server over the network can modify them.
48 </div>
49
50 <div ng-show="header[constants.KEY__HEADER__TIME_UPDATED]"> 44 <div ng-show="header[constants.KEY__HEADER__TIME_UPDATED]">
51 setA: "{{header[constants.KEY__HEADER__SET_A_DESCRIPTIONS][constants.KEY__ SET_DESCRIPTIONS__SECTION]}}" 45 setA: "{{header[constants.KEY__HEADER__SET_A_DESCRIPTIONS][constants.KEY__ SET_DESCRIPTIONS__SECTION]}}"
52 within {{header[constants.KEY__HEADER__SET_A_DESCRIPTIONS][constants.KEY__ SET_DESCRIPTIONS__DIR]}} 46 within {{header[constants.KEY__HEADER__SET_A_DESCRIPTIONS][constants.KEY__ SET_DESCRIPTIONS__DIR]}}
53 <span ng-show="header[constants.KEY__HEADER__SET_A_DESCRIPTIONS][constants .KEY__SET_DESCRIPTIONS__REPO_REVISION]">at <a href="https://skia.googlesource.co m/skia/+/{{header[constants.KEY__HEADER__SET_A_DESCRIPTIONS][constants.KEY__SET_ DESCRIPTIONS__REPO_REVISION]}}">rev {{header[constants.KEY__HEADER__SET_A_DESCRI PTIONS][constants.KEY__SET_DESCRIPTIONS__REPO_REVISION]}}</a></span> 47 <span ng-show="header[constants.KEY__HEADER__SET_A_DESCRIPTIONS][constants .KEY__SET_DESCRIPTIONS__REPO_REVISION]">at <a href="https://skia.googlesource.co m/skia/+/{{header[constants.KEY__HEADER__SET_A_DESCRIPTIONS][constants.KEY__SET_ DESCRIPTIONS__REPO_REVISION]}}">rev {{header[constants.KEY__HEADER__SET_A_DESCRI PTIONS][constants.KEY__SET_DESCRIPTIONS__REPO_REVISION]}}</a></span>
54 <br> 48 <br>
55 setB: "{{header[constants.KEY__HEADER__SET_B_DESCRIPTIONS][constants.KEY__ SET_DESCRIPTIONS__SECTION]}}" 49 setB: "{{header[constants.KEY__HEADER__SET_B_DESCRIPTIONS][constants.KEY__ SET_DESCRIPTIONS__SECTION]}}"
56 within {{header[constants.KEY__HEADER__SET_B_DESCRIPTIONS][constants.KEY__ SET_DESCRIPTIONS__DIR]}} 50 within {{header[constants.KEY__HEADER__SET_B_DESCRIPTIONS][constants.KEY__ SET_DESCRIPTIONS__DIR]}}
57 <span ng-show="header[constants.KEY__HEADER__SET_B_DESCRIPTIONS][constants .KEY__SET_DESCRIPTIONS__REPO_REVISION]">at <a href="https://skia.googlesource.co m/skia/+/{{header[constants.KEY__HEADER__SET_B_DESCRIPTIONS][constants.KEY__SET_ DESCRIPTIONS__REPO_REVISION]}}">rev {{header[constants.KEY__HEADER__SET_B_DESCRI PTIONS][constants.KEY__SET_DESCRIPTIONS__REPO_REVISION]}}</a></span> 51 <span ng-show="header[constants.KEY__HEADER__SET_B_DESCRIPTIONS][constants .KEY__SET_DESCRIPTIONS__REPO_REVISION]">at <a href="https://skia.googlesource.co m/skia/+/{{header[constants.KEY__HEADER__SET_B_DESCRIPTIONS][constants.KEY__SET_ DESCRIPTIONS__REPO_REVISION]}}">rev {{header[constants.KEY__HEADER__SET_B_DESCRI PTIONS][constants.KEY__SET_DESCRIPTIONS__REPO_REVISION]}}</a></span>
58 <br> 52 <br>
59 <a href="{{liveQueryUrl}}">latest raw JSON diffs between these two sets</a ><br> 53 <a href="{{liveQueryUrl}}">latest raw JSON diffs between these two sets</a ><br>
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 </button> 163 </button>
170 </td></tr> 164 </td></tr>
171 </tr></table></td> 165 </tr></table></td>
172 </tr> 166 </tr>
173 </table> 167 </table>
174 168
175 <p> 169 <p>
176 170
177 <!-- Submission UI that we only show in the Pending Approval tab. --> 171 <!-- Submission UI that we only show in the Pending Approval tab. -->
178 <div ng-show="'Pending Approval' == viewingTab"> 172 <div ng-show="'Pending Approval' == viewingTab">
173 <div style="font-size:20px">
174 TODO(epoger): We don't yet support submitting new SKP expectations.
175 </div>
179 <div style="display:inline-block"> 176 <div style="display:inline-block">
180 <button style="font-size:20px" 177 <button style="font-size:20px"
181 ng-click="submitApprovals(filteredImagePairs)" 178 ng-click="submitApprovals(filteredImagePairs)"
182 ng-disabled="submitPending || (filteredImagePairs.length == 0) "> 179 ng-disabled="true || submitPending || (filteredImagePairs.leng th == 0)">
183 Update these {{filteredImagePairs.length}} expectations on the serve r 180 Update these {{filteredImagePairs.length}} expectations on the serve r
184 </button> 181 </button>
185 </div> 182 </div>
186 <div style="display:inline-block"> 183 <div style="display:inline-block">
187 <div style="font-size:20px" 184 <div style="font-size:20px"
188 ng-show="submitPending"> 185 ng-show="submitPending">
189 Submitting, please wait... 186 Submitting, please wait...
190 </div> 187 </div>
191 </div> 188 </div>
192 <div> 189 <div>
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
423 ng-click="toggleSomeImagePairs($index, imagePair[constants.KE Y__IMAGEPAIRS__ROWSPAN])"> 420 ng-click="toggleSomeImagePairs($index, imagePair[constants.KE Y__IMAGEPAIRS__ROWSPAN])">
424 </tr> 421 </tr>
425 </table> <!-- imagePairs --> 422 </table> <!-- imagePairs -->
426 </td></tr></table> <!-- table holding results header + imagePairs table --> 423 </td></tr></table> <!-- table holding results header + imagePairs table -->
427 424
428 </div><!-- main display area of selected tab --> 425 </div><!-- main display area of selected tab -->
429 </div><!-- everything: hide until readyToDisplay --> 426 </div><!-- everything: hide until readyToDisplay -->
430 427
431 </body> 428 </body>
432 </html> 429 </html>
OLDNEW
« no previous file with comments | « gm/rebaseline_server/server.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698