Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 473803002: Tweak the documentation of "fullscreen element ready check" (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
Reviewers:
falken
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Project:
blink
Visibility:
Public.

Description

Tweak the documentation of "fullscreen element ready check" Use |element| for the variable (italic in spec) and add missing word: https://www.w3.org/Bugs/Public/show_bug.cgi?id=26580 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180249

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M Source/core/dom/FullscreenElementStack.cpp View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
PTAL
6 years, 4 months ago (2014-08-14 07:54:51 UTC) #1
falken
lgtm
6 years, 4 months ago (2014-08-14 08:28:24 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-08-14 08:29:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/473803002/1
6 years, 4 months ago (2014-08-14 08:30:16 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 08:31:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 180249

Powered by Google App Engine
This is Rietveld 408576698