Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Unified Diff: Source/core/dom/FullscreenElementStack.cpp

Issue 473803002: Tweak the documentation of "fullscreen element ready check" (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/FullscreenElementStack.cpp
diff --git a/Source/core/dom/FullscreenElementStack.cpp b/Source/core/dom/FullscreenElementStack.cpp
index 075c6f486ed48db1c41c59a0752adaf3678371c1..964fd061ec765d513b4dbc5ede5868675e944fae 100644
--- a/Source/core/dom/FullscreenElementStack.cpp
+++ b/Source/core/dom/FullscreenElementStack.cpp
@@ -171,14 +171,14 @@ void FullscreenElementStack::documentWasDisposed()
bool FullscreenElementStack::elementReady(Element& element, RequestType requestType)
{
- // A fullscreen element ready check for an element returns true if all of the following are
- // true, and false otherwise:
+ // A fullscreen element ready check for an element |element| returns true if all of the
+ // following are true, and false otherwise:
- // element is in a document.
+ // |element| is in a document.
if (!element.inDocument())
return false;
- // element's node document's fullscreen enabled flag is set.
+ // |element|'s node document's fullscreen enabled flag is set.
if (!fullscreenIsAllowedForAllOwners(element.document())) {
if (requestType == PrefixedVideoRequest)
UseCounter::count(element.document(), UseCounter::VideoFullscreenAllowedExemption);
@@ -186,14 +186,14 @@ bool FullscreenElementStack::elementReady(Element& element, RequestType requestT
return false;
}
- // element's node document's fullscreen element stack is either empty or its top element is an
- // ancestor of element.
+ // |element|'s node document's fullscreen element stack is either empty or its top element is an
+ // ancestor of |element|.
if (Element* topElement = fullscreenElementFrom(element.document())) {
if (!element.isDescendantOf(topElement))
return false;
}
- // element has no ancestor element whose local name is iframe and namespace is the HTML
+ // |element| has no ancestor element whose local name is iframe and namespace is the HTML
// namespace.
if (Traversal<HTMLIFrameElement>::firstAncestor(element))
return false;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698