Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 473093002: Revert "Re-land of: Allow paint invalidation containers to cross frame boundaries." (Closed)

Created:
6 years, 4 months ago by leviw_travelin_and_unemployed
Modified:
6 years, 4 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., rune+blink
Project:
blink
Visibility:
Public.

Description

Revert "Re-land of: Allow paint invalidation containers to cross frame boundaries." This reverts commit 51fe8a513278ca949b5848bce3495f69a67072e2. Reason for revert: Broke iframe repainting: https://code.google.com/p/chromium/issues/detail?id=403734. Original issue's description: > Re-land of: Allow paint invalidation containers to cross frame boundaries. > > The previous version had an infinite loop bug in RenderObject when there are two nested frames. > > Previously, the *actual* paint invalidation container, meaning the enclosing > compositing layer / root RenderView, could already have been across a frame boundary. The logic to do this correctly was done via special code in RenderView. > > Instead, generalize the existing mechanisms to find a paint invalidation container > and map rects to repaint container coordinate space to cross frame boundaries. > This simplifies the code, and also causes paint invalidation rects to always be stored > in the coordinate space of their graphics layer backing. The latter is important if we want > to use these rects for determining which parts of a graphics layer need to be painted. > > BUG=401156 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179858 TBR=chrishtr@chromium.org NOTREECHECKS=true BUG=401156 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180315

Patch Set 1 #

Patch Set 2 : Fix compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -52 lines) Patch
M Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerRepainter.cpp View 1 chunk +16 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 1 chunk +4 lines, -1 line 0 comments Download
M Source/core/rendering/RenderObject.cpp View 5 chunks +11 lines, -20 lines 0 comments Download
M Source/core/rendering/RenderView.cpp View 1 5 chunks +25 lines, -30 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
leviw_travelin_and_unemployed
The CQ bit was checked by leviw@chromium.org
6 years, 4 months ago (2014-08-14 23:54:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/473093002/1
6 years, 4 months ago (2014-08-14 23:56:03 UTC) #2
leviw_travelin_and_unemployed
The CQ bit was checked by leviw@chromium.org
6 years, 4 months ago (2014-08-15 00:09:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/473093002/20001
6 years, 4 months ago (2014-08-15 00:11:27 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-15 02:04:53 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 02:21:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180315

Powered by Google App Engine
This is Rietveld 408576698