Move ALL_BROWSER_TYPES constant to a FindAllBrowsers() function, so that it doesn't run unnecessari…

Move ALL_BROWSER_TYPES constant to a FindAllBrowsers() function, so that it doesn't run unnecessarily.
This is needed for https://codereview.chromium.org/461043003/, which does an http request to find available browsers.

BUG=401180
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289828

[sullivan, 2014-08-14 15:51:27]

This gets around code that generates the browser list running at the module
level, so that we're not firing http requests during unit tests, etc.

[tonyg, 2014-08-14 15:56:24]

lgtm with a comment

https://codereview.chromium.org/472913002/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py
(right):

https://codereview.chromium.org/472913002/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py:179:
def FindAllBrowsers():
FindAllBrowserTypes()? That way it's clear were returning strings and not
PossibleBrowsers.

[sullivan, 2014-08-14 16:11:39]

https://codereview.chromium.org/472913002/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py
(right):

https://codereview.chromium.org/472913002/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py:179:
def FindAllBrowsers():
On 2014/08/14 15:56:24, tonyg wrote:
> FindAllBrowserTypes()? That way it's clear were returning strings and not
> PossibleBrowsers.

Done.

[sullivan, 2014-08-14 16:11:42]

The CQ bit was checked by sullivan@chromium.org

[commit-bot: I haz the power, 2014-08-14 16:12:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sullivan@chromium.org/472913002/20001

[commit-bot: I haz the power, 2014-08-14 22:56:10]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-08-14 23:03:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-14 23:03:48]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tonyg, 2014-08-14 23:07:10]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-08-14 23:12:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sullivan@chromium.org/472913002/20001

[commit-bot: I haz the power, 2014-08-15 05:08:30]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)

[commit-bot: I haz the power, 2014-08-15 05:21:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-15 05:21:22]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)

[sullivan, 2014-08-15 06:52:20]

The CQ bit was checked by sullivan@chromium.org

[commit-bot: I haz the power, 2014-08-15 06:54:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sullivan@chromium.org/472913002/20001

[commit-bot: I haz the power, 2014-08-15 09:24:10]

Committed patchset #2 (20001) as 289828