tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py - Issue 472913002: Move ALL_BROWSER_TYPES constant to a FindAllBrowsers() function, so that it doesn't run unnecessari…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py

Issue 472913002: Move ALL_BROWSER_TYPES constant to a FindAllBrowsers() function, so that it doesn't run unnecessari… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Renamed FindAllBrowsers to FindAllBrowserTypes Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py ('k') | tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py b/tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py

index 1b09b4298d7eb0c22fecc92a63dc00ec0dcd407c..de9ac425d86eb08de88dd4948b29a08ab9697153 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py

@@ -35,8 +35,6 @@ class PossibleIOSBrowser(possible_browser.PossibleBrowser):

# description of the browser.

IOS_BROWSERS = {'CriOS': 'ios-chrome', 'Version': 'ios-safari'}

-ALL_BROWSER_TYPES = IOS_BROWSERS.values()

DEVICE_LIST_URL = 'http://127.0.0.1:9221/json'

IOS_WEBKIT_DEBUG_PROXY = 'ios_webkit_debug_proxy'

@@ -50,6 +48,10 @@ def CanFindAvailableBrowsers():

return False # TODO(baxley): Implement me.

+def FindAllBrowserTypes():

+ return IOS_BROWSERS.values()

def FindAllAvailableBrowsers(finder_options):

"""Find all running iOS browsers on connected devices."""

ios_device_attached = False