tools/telemetry/telemetry/core/browser_options.py - Issue 472913002: Move ALL_BROWSER_TYPES constant to a FindAllBrowsers() function, so that it doesn't run unnecessari…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/browser_options.py

Issue 472913002: Move ALL_BROWSER_TYPES constant to a FindAllBrowsers() function, so that it doesn't run unnecessari… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Renamed FindAllBrowsers to FindAllBrowserTypes Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/browser_options.py

diff --git a/tools/telemetry/telemetry/core/browser_options.py b/tools/telemetry/telemetry/core/browser_options.py

index 211d1de65a0df10037338745e9dd38caeae578e8..f28272d35fb4868c95108696db0126081b1d7d05 100644

--- a/tools/telemetry/telemetry/core/browser_options.py

+++ b/tools/telemetry/telemetry/core/browser_options.py

@@ -63,7 +63,7 @@ class BrowserFinderOptions(optparse.Values):

default=None,

help='Browser type to run, '

'in order of priority. Supported values: list,%s' %

- ','.join(browser_finder.ALL_BROWSER_TYPES))

+ ','.join(browser_finder.FindAllBrowserTypes()))

group.add_option('--browser-executable',

dest='browser_executable',

help='The exact browser to run.')

« no previous file with comments | « tools/telemetry/telemetry/core/browser_finder.py ('k') | no next file » | no next file with comments »