Issue 472793002: DevTools: Make TextEditor.tokenAtTextPosition() return exclusive end column

Issue 472793002: DevTools: Make TextEditor.tokenAtTextPosition() return exclusive end column (Closed)

Created:
6 years, 4 months ago by apavlov

Modified:
6 years, 4 months ago

Reviewers:
lushnikov

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Make TextEditor.tokenAtTextPosition() return exclusive end column All call sites compensate for the inclusive end column by adding 1 to token.endColumn to get the actual token text. R=lushnikov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180260

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix remaining cases #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -15 lines)			Patch
M	LayoutTests/inspector/editor/text-editor-token-at-position-expected.txt	View		1 chunk	+10 lines, -10 lines	0 comments	Download
M	Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/sources/CSSSourceFrame.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/sources/JavaScriptSourceFrame.js	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

lushnikov

https://codereview.chromium.org/472793002/diff/1/Source/devtools/front_end/sources/JavaScriptSourceFrame.js File Source/devtools/front_end/sources/JavaScriptSourceFrame.js (right): https://codereview.chromium.org/472793002/diff/1/Source/devtools/front_end/sources/JavaScriptSourceFrame.js#newcode531 Source/devtools/front_end/sources/JavaScriptSourceFrame.js:531: endColumn: token.endColumn this should be fixed as well.

6 years, 4 months ago (2014-08-14 11:00:55 UTC) #2

lushnikov

On 2014/08/14 11:00:55, lushnikov wrote: > https://codereview.chromium.org/472793002/diff/1/Source/devtools/front_end/sources/JavaScriptSourceFrame.js > File Source/devtools/front_end/sources/JavaScriptSourceFrame.js (right): > > https://codereview.chromium.org/472793002/diff/1/Source/devtools/front_end/sources/JavaScriptSourceFrame.js#newcode531 > ...

6 years, 4 months ago (2014-08-14 11:38:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/472793002/20001

6 years, 4 months ago (2014-08-14 11:39:13 UTC) #5

commit-bot: I haz the power

6 years, 4 months ago (2014-08-14 14:39:11 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (20001) as 180260

Expand Messages | Collapse Messages