Source/devtools/front_end/sources/CSSSourceFrame.js - Issue 472793002: DevTools: Make TextEditor.tokenAtTextPosition() return exclusive end column

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/sources/CSSSourceFrame.js

Issue 472793002: DevTools: Make TextEditor.tokenAtTextPosition() return exclusive end column (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix remaining cases Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js ('k') | Source/devtools/front_end/sources/JavaScriptSourceFrame.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/sources/CSSSourceFrame.js

diff --git a/Source/devtools/front_end/sources/CSSSourceFrame.js b/Source/devtools/front_end/sources/CSSSourceFrame.js

index 3feba90437b4b7e63088cbefe0f28e886c55d7bb..bd90f3f1e7b5ff0fc316f9681c721d3560a78b54 100644

--- a/Source/devtools/front_end/sources/CSSSourceFrame.js

+++ b/Source/devtools/front_end/sources/CSSSourceFrame.js

@@ -84,7 +84,7 @@ WebInspector.CSSSourceFrame.prototype = {

if (token.type !== "css-number")

return false;

- var cssUnitRange = new WebInspector.TextRange(selection.startLine, token.startColumn, selection.startLine, token.endColumn + 1);

+ var cssUnitRange = new WebInspector.TextRange(selection.startLine, token.startColumn, selection.startLine, token.endColumn);

var cssUnitText = this.textEditor.copyRange(cssUnitRange);

var newUnitText = this._modifyUnit(cssUnitText, change);

if (!newUnitText)