Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js - Issue 472793002: DevTools: Make TextEditor.tokenAtTextPosition() return exclusive end column

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js

Issue 472793002: DevTools: Make TextEditor.tokenAtTextPosition() return exclusive end column (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix remaining cases Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector/editor/text-editor-token-at-position-expected.txt ('k') | Source/devtools/front_end/sources/CSSSourceFrame.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js

diff --git a/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js b/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js

index c8d8f77bf4bff3252a7f5872d8592edcdd9a2c98..4764300ffa8a35887d14a67b06921c413f4e2772 100644

--- a/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js

+++ b/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js

@@ -734,7 +734,7 @@ WebInspector.CodeMirrorTextEditor.prototype = {

return null;

return {

startColumn: token.start,

- endColumn: token.end - 1,

+ endColumn: token.end,

type: token.type

};