Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1242)

Issue 472243002: Don't allow setting properties on scriptable v8 plugin backing objects (Closed)

Created:
6 years, 4 months ago by raymes
Modified:
6 years, 4 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium, chrome-apps-syd-reviews_chromium.org, jochen (gone - plz use gerrit), dmichael (off chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Don't allow setting properties on scriptable v8 plugin objects Plugin elements can be backed by v8 objects which are used for scripting from JS into the plugin. There are no longer any use cases where we need to allow setting properties on the backing object as a result of setting the property on the plugin element. As a result we can remove the call to the backing v8 object. Note that this should only affect Pepper plugins that support scripting (Flash and PDF being the ones of importance) but I have verified that they do not need this. When NPAPI is removed, we should be able to remove the corresponding NPObject codepath. BUG=351636 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180581

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
raymes
6 years, 4 months ago (2014-08-19 04:27:38 UTC) #1
haraken
LGTM
6 years, 4 months ago (2014-08-19 11:44:09 UTC) #2
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 4 months ago (2014-08-19 16:16:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/472243002/1
6 years, 4 months ago (2014-08-19 16:18:12 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 17:07:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 180581

Powered by Google App Engine
This is Rietveld 408576698