Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp - Issue 472243002: Don't allow setting properties on scriptable v8 plugin backing objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp

Issue 472243002: Don't allow setting properties on scriptable v8 plugin backing objects (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp

diff --git a/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp b/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp

index 99b9ad6ff6469c22b6e3cc2081c770c88773d5f0..5b538842f816de4f4c1ae32608113ae30a4b105d 100644

--- a/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp

+++ b/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp

@@ -100,9 +100,6 @@ void setScriptableObjectProperty(PropertyType property, v8::Local<v8::Value> val

callNpObjectSetter(instance, property, value, info);

return;

}

- if (instance->Set(property, value))

- v8SetReturnValue(info, value);

}

} // namespace

« no previous file with comments | « no previous file | no next file » | no next file with comments »