Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Side by Side Diff: Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp

Issue 472243002: Don't allow setting properties on scriptable v8 plugin backing objects (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2014 Opera Software ASA. All rights reserved. 3 * Copyright (C) 2014 Opera Software ASA. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 return; 93 return;
94 94
95 // We need to directly call setter on NPObject to be able to detect 95 // We need to directly call setter on NPObject to be able to detect
96 // situation where NPObject notifies it does not possess the property 96 // situation where NPObject notifies it does not possess the property
97 // to be able to lookup standard DOM property. 97 // to be able to lookup standard DOM property.
98 // This information is lost when retrieving it through v8::Object. 98 // This information is lost when retrieving it through v8::Object.
99 if (isWrappedNPObject(instance)) { 99 if (isWrappedNPObject(instance)) {
100 callNpObjectSetter(instance, property, value, info); 100 callNpObjectSetter(instance, property, value, info);
101 return; 101 return;
102 } 102 }
103
104 if (instance->Set(property, value))
105 v8SetReturnValue(info, value);
106 } 103 }
107 } // namespace 104 } // namespace
108 105
109 void V8HTMLAppletElement::namedPropertyGetterCustom(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info) 106 void V8HTMLAppletElement::namedPropertyGetterCustom(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)
110 { 107 {
111 getScriptableObjectProperty<V8HTMLAppletElement>(name, info); 108 getScriptableObjectProperty<V8HTMLAppletElement>(name, info);
112 } 109 }
113 110
114 void V8HTMLEmbedElement::namedPropertyGetterCustom(v8::Local<v8::String> name, c onst v8::PropertyCallbackInfo<v8::Value>& info) 111 void V8HTMLEmbedElement::namedPropertyGetterCustom(v8::Local<v8::String> name, c onst v8::PropertyCallbackInfo<v8::Value>& info)
115 { 112 {
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 UseCounter::count(V8HTMLEmbedElement::toNative(info.Holder())->document(), U seCounter::HTMLEmbedElementLegacyCall); 199 UseCounter::count(V8HTMLEmbedElement::toNative(info.Holder())->document(), U seCounter::HTMLEmbedElementLegacyCall);
203 } 200 }
204 201
205 void V8HTMLObjectElement::legacyCallCustom(const v8::FunctionCallbackInfo<v8::Va lue>& info) 202 void V8HTMLObjectElement::legacyCallCustom(const v8::FunctionCallbackInfo<v8::Va lue>& info)
206 { 203 {
207 invokeOnScriptableObject<V8HTMLObjectElement>(info); 204 invokeOnScriptableObject<V8HTMLObjectElement>(info);
208 UseCounter::count(V8HTMLObjectElement::toNative(info.Holder())->document(), UseCounter::HTMLObjectElementLegacyCall); 205 UseCounter::count(V8HTMLObjectElement::toNative(info.Holder())->document(), UseCounter::HTMLObjectElementLegacyCall);
209 } 206 }
210 207
211 } // namespace blink 208 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698