Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Issue 472083003: Mojom cpp bindings: Enable non-nullable check. (Closed)

Created:
6 years, 4 months ago by yzshen1
Modified:
6 years, 4 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mojom cpp bindings: Enable non-nullable check. BUG=324170 TEST=All tests pass Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290792

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -33 lines) Patch
M device/serial/serial.mojom View 1 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/apps/js/test/js_to_cpp.mojom View 1 chunk +6 lines, -6 lines 0 comments Download
M mojo/public/cpp/bindings/lib/validation_errors.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_factory.mojom View 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_service.mojom View 2 chunks +10 lines, -10 lines 0 comments Download
M mojo/services/public/interfaces/input_events/input_events.mojom View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yzshen1
Hi, Ben. Would you please take a look? Thanks! Please let me know whether the ...
6 years, 4 months ago (2014-08-19 18:28:00 UTC) #1
darin (slow to review)
LGTM (Ben is out on vacation for a couple weeks.)
6 years, 4 months ago (2014-08-19 20:06:08 UTC) #2
yzshen1
On 2014/08/19 20:06:08, darin wrote: > LGTM > > (Ben is out on vacation for ...
6 years, 4 months ago (2014-08-19 22:52:53 UTC) #3
darin (slow to review)
serial.mojom LGTM as well
6 years, 4 months ago (2014-08-19 22:57:06 UTC) #4
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 4 months ago (2014-08-20 07:30:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/472083003/10007
6 years, 4 months ago (2014-08-20 07:32:13 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 08:30:32 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (10007) as 290792

Powered by Google App Engine
This is Rietveld 408576698