mojo/public/cpp/bindings/lib/validation_errors.cc - Issue 472083003: Mojom cpp bindings: Enable non-nullable check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/lib/validation_errors.cc

Issue 472083003: Mojom cpp bindings: Enable non-nullable check. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/cpp/bindings/lib/validation_errors.cc

diff --git a/mojo/public/cpp/bindings/lib/validation_errors.cc b/mojo/public/cpp/bindings/lib/validation_errors.cc

index afa577df1553c99428d2848a18f67720413fbe6c..0af7790ea192d7a153dede77207a5d4c08803439 100644

--- a/mojo/public/cpp/bindings/lib/validation_errors.cc

+++ b/mojo/public/cpp/bindings/lib/validation_errors.cc

@@ -86,7 +86,8 @@ SerializationWarningObserverForTesting::

}

bool IsNonNullableValidationEnabled() {

- return g_validation_error_observer || g_serialization_warning_observer;

+ // TODO(yzshen): Remove this function and all call sites.

+ return true;

}

} // namespace internal