Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1593)

Unified Diff: mojo/services/public/interfaces/view_manager/view_manager.mojom

Issue 472083003: Mojom cpp bindings: Enable non-nullable check. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/services/public/interfaces/input_events/input_events.mojom ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/public/interfaces/view_manager/view_manager.mojom
diff --git a/mojo/services/public/interfaces/view_manager/view_manager.mojom b/mojo/services/public/interfaces/view_manager/view_manager.mojom
index 411f8cc7c107f09227dfdfb2559674e89fed20c8..32d83d77fa6c47357e04a80a5056288168c03c29 100644
--- a/mojo/services/public/interfaces/view_manager/view_manager.mojom
+++ b/mojo/services/public/interfaces/view_manager/view_manager.mojom
@@ -34,7 +34,7 @@ interface ViewManagerInitService {
// typically referred to as the "window manager", and will have a specific
// definition of where within its View hierarchy to embed an unparented URL.
// See ViewManagerService below for more details about |service_provider|.
- Embed(string url, ServiceProvider service_provider) => (bool success);
+ Embed(string url, ServiceProvider? service_provider) => (bool success);
};
// Views are identified by a uint32. The upper 16 bits are the connection id,
@@ -136,7 +136,7 @@ interface ViewManagerService {
// any services it provided are not broken and continue to be valid.
Embed(string url,
uint32 view_id,
- ServiceProvider service_provider) => (bool success);
+ ServiceProvider? service_provider) => (bool success);
// TODO(sky): move these to a separate interface when FIFO works.
@@ -154,7 +154,7 @@ interface ViewManagerClient {
OnEmbed(uint16 connection_id,
string embedder_url,
ViewData root,
- ServiceProvider& service_provider);
+ ServiceProvider&? service_provider);
// Invoked when a view's bounds have changed.
OnViewBoundsChanged(uint32 view, mojo.Rect old_bounds, mojo.Rect new_bounds);
@@ -188,7 +188,7 @@ interface ViewManagerClient {
// once support for derived FIFOs is landed.
// Requests the window manager create a "top level" view embedding |url|.
- Embed(string url, ServiceProvider& service_provider);
+ Embed(string url, ServiceProvider&? service_provider);
// Requests the view manager dispatch the event.
DispatchOnViewInputEvent(mojo.Event event);
« no previous file with comments | « mojo/services/public/interfaces/input_events/input_events.mojom ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698