Omnibox: Prevent Asynchronous Suggestions from Changing Default Match

components/omnibox/search_suggestion_parser.cc

Index: components/omnibox/search_suggestion_parser.cc
diff --git a/components/omnibox/search_suggestion_parser.cc b/components/omnibox/search_suggestion_parser.cc
index a481def345dee8aec352842f70e423d10125faeb..a0030442a601ee7ab66616c6bfb1078470ed60b4 100644
--- a/components/omnibox/search_suggestion_parser.cc
+++ b/components/omnibox/search_suggestion_parser.cc
@@ -49,6 +49,7 @@ SearchSuggestionParser::Result::Result(bool from_keyword_provider,
       type_(type),
       relevance_(relevance),
       relevance_from_server_(relevance_from_server),
+      received_after_last_keystroke_(true),

[msw, 2014/08/15 21:04:39]

Is there any case beyond history that generates synchronous search suggestions?

[Mark P, 2014/08/15 22:09:22]

Good point.  I used code search and discovered Shortcuts does as well.  Fixed
it.

(Shortcuts creates suggestions with the CreateSearchSuggestion helper function
that has a ton of default values.  I fixed shortcuts by setting the right
default value there.  Shortcuts is the only caller of that helper function with
that pile of default values.)

FYI, this would not have mattered in practice because no shortcuts results
empirically score high enough to inline at the moment.

[msw, 2014/08/15 23:31:10]

Acknowledged.

       deletion_url_(deletion_url) {}
 
 SearchSuggestionParser::Result::~Result() {}