Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Unified Diff: components/omnibox/search_suggestion_parser.h

Issue 471673002: Omnibox: Prevent Asynchronous Suggestions from Changing Default Match (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: better resolve rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/search_suggestion_parser.h
diff --git a/components/omnibox/search_suggestion_parser.h b/components/omnibox/search_suggestion_parser.h
index f65a0ba76cf9ba7bc4e27b9b352683ab9eed32f7..4d777a6617949f50a87eb84f1a8019dc2f3a1c03 100644
--- a/components/omnibox/search_suggestion_parser.h
+++ b/components/omnibox/search_suggestion_parser.h
@@ -54,6 +54,13 @@ class SearchSuggestionParser {
AutocompleteMatchType::Type type() const { return type_; }
int relevance() const { return relevance_; }
void set_relevance(int relevance) { relevance_ = relevance; }
+ bool received_after_last_keystroke() const {
+ return received_after_last_keystroke_;
+ }
+ void set_received_after_last_keystroke(
+ bool received_after_last_keystroke) {
+ received_after_last_keystroke_ = received_after_last_keystroke;
+ }
bool relevance_from_server() const { return relevance_from_server_; }
void set_relevance_from_server(bool relevance_from_server) {
@@ -90,6 +97,10 @@ class SearchSuggestionParser {
// there.
bool relevance_from_server_;
+ // Whether this result was received asynchronously after the last
+ // keystroke, otherwise it must have come from prior cached results.
msw 2014/08/15 21:04:39 nit: or from a synchronous provider, right?
Mark P 2014/08/15 22:09:22 Nice clarification. Added.
+ bool received_after_last_keystroke_;
+
// Optional deletion URL provided with suggestions. Fetching this URL
// should result in some reasonable deletion behaviour on the server,
// e.g. deleting this term out of a user's server-side search history.

Powered by Google App Engine
This is Rietveld 408576698