Omnibox: Prevent Asynchronous Suggestions from Changing Default Match

components/omnibox/search_suggestion_parser.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/omnibox/search_suggestion_parser.h"
 
 #include "base/i18n/icu_string_conversions.h"
 #include "base/json/json_string_value_serializer.h"
 #include "base/json/json_writer.h"
 #include "base/logging.h"
@@ skipping 31 matching lines @@
 
 SearchSuggestionParser::Result::Result(bool from_keyword_provider,
                                        int relevance,
                                        bool relevance_from_server,
                                        AutocompleteMatchType::Type type,
                                        const std::string& deletion_url)
     : from_keyword_provider_(from_keyword_provider),
       type_(type),
       relevance_(relevance),
       relevance_from_server_(relevance_from_server),
+      received_after_last_keystroke_(true),

[msw, 2014/08/15 21:04:39]

Is there any case beyond history that generates synchronous search suggestions?

[Mark P, 2014/08/15 22:09:22]

Good point.  I used code search and discovered Shortcuts does as well.  Fixed
it.

(Shortcuts creates suggestions with the CreateSearchSuggestion helper function
that has a ton of default values.  I fixed shortcuts by setting the right
default value there.  Shortcuts is the only caller of that helper function with
that pile of default values.)

FYI, this would not have mattered in practice because no shortcuts results
empirically score high enough to inline at the moment.

[msw, 2014/08/15 23:31:10]

Acknowledged.

       deletion_url_(deletion_url) {}
 
 SearchSuggestionParser::Result::~Result() {}
 
 // SearchSuggestionParser::SuggestResult ---------------------------------------
 
 SearchSuggestionParser::SuggestResult::SuggestResult(
     const base::string16& suggestion,
     AutocompleteMatchType::Type type,
     const base::string16& match_contents,
@@ skipping 433 matching lines @@
       continue;
     const base::DictionaryValue* imageData = NULL;
     imageLine->GetDictionary("i", &imageData);
     if (!imageData)
       continue;
     std::string imageUrl;
     imageData->GetString("d", &imageUrl);
     urls->push_back(GURL(imageUrl));
   }
 }