src/effects/SkTableMaskFilter.cpp - Issue 471473002: Optimize CSS box-shadow performance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkTableMaskFilter.cpp

Issue 471473002: Optimize CSS box-shadow performance (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: store SkMask and SkCachedData in cache Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkTableMaskFilter.cpp

diff --git a/src/effects/SkTableMaskFilter.cpp b/src/effects/SkTableMaskFilter.cpp

index 42b4ab6ff6d41cbdc3b613878cb0b7c17be0fcc3..90ed2ebdee89f4fdc0589b4e771a2f716ea8d982 100644

--- a/src/effects/SkTableMaskFilter.cpp

+++ b/src/effects/SkTableMaskFilter.cpp

@@ -25,7 +25,7 @@ SkTableMaskFilter::SkTableMaskFilter(const uint8_t table[256]) {

SkTableMaskFilter::~SkTableMaskFilter() {}

bool SkTableMaskFilter::filterMask(SkMask* dst, const SkMask& src,

- const SkMatrix&, SkIPoint* margin) const {

+ const SkMatrix&, SkIPoint* margin, SkCachedData** data) const {

if (src.fFormat != SkMask::kA8_Format) {

return false;

}