src/effects/SkEmbossMaskFilter.cpp - Issue 471473002: Optimize CSS box-shadow performance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkEmbossMaskFilter.cpp

Issue 471473002: Optimize CSS box-shadow performance (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: store SkMask and SkCachedData in cache Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkEmbossMaskFilter.cpp

diff --git a/src/effects/SkEmbossMaskFilter.cpp b/src/effects/SkEmbossMaskFilter.cpp

index 4841b92816459ccd9c61b7e413d0b885cdeb38a1..a810e703fea424568c28c041a26348817a6d216f 100644

--- a/src/effects/SkEmbossMaskFilter.cpp

+++ b/src/effects/SkEmbossMaskFilter.cpp

@@ -75,10 +75,10 @@ SkMask::Format SkEmbossMaskFilter::getFormat() const {

}

bool SkEmbossMaskFilter::filterMask(SkMask* dst, const SkMask& src,

- const SkMatrix& matrix, SkIPoint* margin) const {

+ const SkMatrix& matrix, SkIPoint* margin, SkCachedData** data) const {

SkScalar sigma = matrix.mapRadius(fBlurSigma);

- if (!SkBlurMask::BoxBlur(dst, src, sigma, kInner_SkBlurStyle, kLow_SkBlurQuality)) {

+ if (!SkBlurMask::BoxBlur(dst, NULL, src, sigma, kInner_SkBlurStyle, kLow_SkBlurQuality)) {

return false;

}