src/gpu/SkGpuDevice.cpp - Issue 471473002: Optimize CSS box-shadow performance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/SkGpuDevice.cpp

Issue 471473002: Optimize CSS box-shadow performance (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: store SkMask and SkCachedData in cache Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/SkGpuDevice.cpp

diff --git a/src/gpu/SkGpuDevice.cpp b/src/gpu/SkGpuDevice.cpp

index 6f4d1a6f99ea6b83fc5ac1ae99a78704678e8228..367ad5022917021684da0f4f84ee3d07a3bf93b5 100644

--- a/src/gpu/SkGpuDevice.cpp

+++ b/src/gpu/SkGpuDevice.cpp

@@ -592,7 +592,7 @@ bool draw_with_mask_filter(GrContext* context, const SkPath& devPath,

}

SkAutoMaskFreeImage autoSrc(srcM.fImage);

- if (!filter->filterMask(&dstM, srcM, context->getMatrix(), NULL)) {

+ if (!filter->filterMask(&dstM, srcM, context->getMatrix(), NULL, NULL)) {

return false;

}

// this will free-up dstM when we're done (allocated in filterMask())