Issue 471113002: Revert of Remove unnecessary static function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 471113002: Revert of Remove unnecessary static function (Closed)

Created:
6 years, 4 months ago by danakj

Modified:
6 years, 4 months ago

Reviewers:
enne (OOO), hj.r.chung

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Revert of Remove unnecessary static function (patchset #2 of https://codereview.chromium.org/444983002/) Reason for revert: Perf regression, due to the method no longer being inline, and using doubles instead of floats. Original issue's description: > Remove unnecessary static function > > Use gfx::CrossProduct() instead of defining a new static function. > > BUG= > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288372 TBR=enne@chromium.org,heejin.r.chung@samsung.com NOTREECHECKS=true NOTRY=true BUG=402552 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289645

Created: 6 years, 4 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -7 lines)			Patch
	M	cc/trees/layer_sorter.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
	M	cc/trees/layer_sorter.cc	View		3 chunks	+8 lines, -3 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/471113002/1

6 years, 4 months ago (2014-08-14 17:42:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 289645