Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 470883002: Add |WebTextDirection toWebTextDirection(TextDirection)|. (Closed)

Created:
6 years, 4 months ago by tkent
Modified:
6 years, 4 months ago
Reviewers:
keishi
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

Add |WebTextDirection toWebTextDirection(TextDirection)|. We need to add "platform" to public/web/DEPS in order to include platform/text/TextDirection.h in WebTextDirection.h. This change should have no problems because we already have "core" dependency, and "core" depends on "platform." TEST=none; no behavior changes. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180316

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -24 lines) Patch
M Source/web/ChromeClientImpl.cpp View 1 chunk +2 lines, -7 lines 0 comments Download
M Source/web/ExternalPopupMenu.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M Source/web/PopupContainer.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M Source/web/ValidationMessageClientImpl.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/WebNotification.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download
M Source/web/WebPopupMenuImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M public/web/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M public/web/WebTextDirection.h View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
tkent
Would you review this please?
6 years, 4 months ago (2014-08-14 07:49:54 UTC) #1
keishi
LGTM
6 years, 4 months ago (2014-08-14 07:52:54 UTC) #2
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 4 months ago (2014-08-14 22:44:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/470883002/1
6 years, 4 months ago (2014-08-14 22:45:32 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-14 22:46:45 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/web/WebNotification.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 4 months ago (2014-08-14 22:46:46 UTC) #6
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 4 months ago (2014-08-14 22:55:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/470883002/20001
6 years, 4 months ago (2014-08-14 22:57:01 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 02:25:49 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180316

Powered by Google App Engine
This is Rietveld 408576698