Source/web/ExternalPopupMenu.cpp - Issue 470883002: Add |WebTextDirection toWebTextDirection(TextDirection)|.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ExternalPopupMenu.cpp

Issue 470883002: Add |WebTextDirection toWebTextDirection(TextDirection)|. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/ExternalPopupMenu.cpp

diff --git a/Source/web/ExternalPopupMenu.cpp b/Source/web/ExternalPopupMenu.cpp

index c4b89a3e675781c7e35d6e4372cc75c84bbdb704..52d6052afad2f891346bc06833e73a99c50d40a0 100644

--- a/Source/web/ExternalPopupMenu.cpp

+++ b/Source/web/ExternalPopupMenu.cpp

@@ -200,10 +200,7 @@ void ExternalPopupMenu::getPopupMenuInfo(WebPopupMenuInfo* info)

popupItem.type = WebMenuItemInfo::Option;

popupItem.enabled = m_popupMenuClient->itemIsEnabled(i);

popupItem.checked = m_popupMenuClient->itemIsSelected(i);

- if (style.textDirection() == RTL)

- popupItem.textDirection = WebTextDirectionRightToLeft;

- else

- popupItem.textDirection = WebTextDirectionLeftToRight;

+ popupItem.textDirection = toWebTextDirection(style.textDirection());

popupItem.hasTextDirectionOverride = style.hasTextDirectionOverride();

}

« no previous file with comments | « Source/web/ChromeClientImpl.cpp ('k') | Source/web/PopupContainer.cpp » ('j') | no next file with comments »