Source/web/WebPopupMenuImpl.cpp - Issue 470883002: Add |WebTextDirection toWebTextDirection(TextDirection)|.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebPopupMenuImpl.cpp

Issue 470883002: Add |WebTextDirection toWebTextDirection(TextDirection)|. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebPopupMenuImpl.cpp

diff --git a/Source/web/WebPopupMenuImpl.cpp b/Source/web/WebPopupMenuImpl.cpp

index b769087e4c47b4cbdefd5b1ad0a2d858f1b42771..49896f487dbf1557b19974e2e04134c2d89c962d 100644

--- a/Source/web/WebPopupMenuImpl.cpp

+++ b/Source/web/WebPopupMenuImpl.cpp

@@ -119,7 +119,7 @@ void WebPopupMenuImpl::handleMouseMove(const WebMouseEvent& event)

// We cannot call setToolTipText() in PopupContainer, because PopupContainer is in WebCore, and we cannot refer to WebKit from Webcore.

PopupContainer* container = static_cast<PopupContainer*>(m_widget);

- client()->setToolTipText(container->getSelectedItemToolTip(), container->menuStyle().textDirection() == RTL ? WebTextDirectionRightToLeft : WebTextDirectionLeftToRight);

+ client()->setToolTipText(container->getSelectedItemToolTip(), toWebTextDirection(container->menuStyle().textDirection()));

}

« no previous file with comments | « Source/web/WebNotification.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »