Issue 470683002: Revert "Refactor code listening to platform events in content/renderer/."

Issue 470683002: Revert "Refactor code listening to platform events in content/renderer/." (Closed)

Created:
6 years, 4 months ago by adamk

Modified:
6 years, 4 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, Michael van Ouwerkerk, riju_, timvolodine, scottmg, bajones, mlamouri (slow - plz ping)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert "Refactor code listening to platform events in content/renderer/." This reverts https://src.chromium.org/viewvc/chrome?revision=288555&view=revision It caused ASAN failures on the Blink Linux ASAN bots. BUG=403412, 400158 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289596

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+590 lines, -563 lines)			Patch
M	content/content_renderer.gypi	View	4 chunks	+3 lines, -3 lines	0 comments	Download
D	content/public/renderer/platform_event_observer.h	View	1 chunk	+0 lines, -125 lines	0 comments	Download
M	content/public/renderer/renderer_gamepad_provider.h	View	2 chunks	+6 lines, -10 lines	0 comments	Download
M	content/renderer/battery_status/battery_status_dispatcher.h	View	2 chunks	+11 lines, -9 lines	0 comments	Download
M	content/renderer/battery_status/battery_status_dispatcher.cc	View	3 chunks	+18 lines, -11 lines	0 comments	Download
M	content/renderer/battery_status/battery_status_dispatcher_unittest.cc	View	4 chunks	+52 lines, -13 lines	0 comments	Download
A	content/renderer/battery_status/fake_battery_status_dispatcher.h	View	1 chunk	+32 lines, -0 lines	0 comments	Download
A	content/renderer/battery_status/fake_battery_status_dispatcher.cc	View	1 chunk	+28 lines, -0 lines	0 comments	Download
M	content/renderer/device_sensors/device_light_event_pump.h	View	1 chunk	+7 lines, -9 lines	0 comments	Download
M	content/renderer/device_sensors/device_light_event_pump.cc	View	2 chunks	+23 lines, -17 lines	0 comments	Download
M	content/renderer/device_sensors/device_light_event_pump_unittest.cc	View	4 chunks	+5 lines, -10 lines	0 comments	Download
M	content/renderer/device_sensors/device_motion_event_pump.h	View	1 chunk	+11 lines, -11 lines	0 comments	Download
M	content/renderer/device_sensors/device_motion_event_pump.cc	View	3 chunks	+18 lines, -14 lines	0 comments	Download
M	content/renderer/device_sensors/device_motion_event_pump_unittest.cc	View	3 chunks	+5 lines, -6 lines	0 comments	Download
M	content/renderer/device_sensors/device_orientation_event_pump.h	View	1 chunk	+11 lines, -11 lines	0 comments	Download
M	content/renderer/device_sensors/device_orientation_event_pump.cc	View	3 chunks	+18 lines, -15 lines	0 comments	Download
M	content/renderer/device_sensors/device_orientation_event_pump_unittest.cc	View	6 chunks	+6 lines, -13 lines	0 comments	Download
M	content/renderer/device_sensors/device_sensor_event_pump.h	View	2 chunks	+17 lines, -55 lines	0 comments	Download
A	content/renderer/device_sensors/device_sensor_event_pump.cc	View	1 chunk	+87 lines, -0 lines	0 comments	Download
M	content/renderer/gamepad_shared_memory_reader.h	View	1 chunk	+16 lines, -10 lines	0 comments	Download
M	content/renderer/gamepad_shared_memory_reader.cc	View	4 chunks	+42 lines, -20 lines	0 comments	Download
M	content/renderer/render_thread_impl.h	View	5 chunks	+12 lines, -0 lines	0 comments	Download
M	content/renderer/render_thread_impl.cc	View	3 chunks	+10 lines, -1 line	0 comments	Download
M	content/renderer/renderer_webkitplatformsupport_impl.h	View	6 chunks	+13 lines, -18 lines	0 comments	Download
M	content/renderer/renderer_webkitplatformsupport_impl.cc	View	7 chunks	+125 lines, -100 lines	0 comments	Download
D	content/renderer/screen_orientation/screen_orientation_observer.h	View	1 chunk	+0 lines, -31 lines	0 comments	Download
D	content/renderer/screen_orientation/screen_orientation_observer.cc	View	1 chunk	+0 lines, -29 lines	0 comments	Download
M	content/shell/renderer/test_runner/gamepad_controller.h	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	content/shell/renderer/test_runner/gamepad_controller.cc	View	4 chunks	+8 lines, -13 lines	0 comments	Download
M	content/test/layouttest_support.cc	View	3 chunks	+2 lines, -6 lines	0 comments	Download