Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1225)

Issue 470443002: Revert of Rename WebAnimation to WebCompositorAnimation (Closed)

Created:
6 years, 4 months ago by samli
Modified:
6 years, 4 months ago
CC:
abarth-chromium, darktears, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, Rik, danakj, dglazkov+blink, krit, dstockwell, Eric Willigers, jamesr, jbroman, Mike Lawther (Google), pdr., rjwright, rwlbuis, Stephen Chennney, shans, Steve Block, Timothy Loh
Project:
blink
Visibility:
Public.

Description

Revert of Rename WebAnimation to WebCompositorAnimation (patchset #5 of https://codereview.chromium.org/412123002/) Reason for revert: Failure: crbug.com/402897 Original issue's description: > Rename WebAnimation to WebCompositorAnimation > > Change WebAnimation to WebCompositorAnimation > Change WebAnimationCurve to WebCompositorAnimationCurve > Change WebAnimationDelegate to WebCompositorAnimationDelegate > > This is patch 3 of 3. It builds on http://crrev.com/413983002 > > BUG=396358 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179910

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+373 lines, -266 lines) Patch
M Source/core/animation/AnimationTranslationUtilTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/CompositorAnimations.cpp View 9 chunks +31 lines, -31 lines 0 comments Download
M Source/core/animation/CompositorAnimationsImpl.h View 2 chunks +3 lines, -5 lines 0 comments Download
M Source/core/animation/CompositorAnimationsTest.cpp View 19 chunks +57 lines, -57 lines 0 comments Download
M Source/core/animation/CompositorAnimationsTestHelper.h View 4 chunks +22 lines, -22 lines 0 comments Download
M Source/platform/graphics/GraphicsLayer.h View 12 chunks +30 lines, -30 lines 0 comments Download
M Source/platform/graphics/GraphicsLayer.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M Source/platform/graphics/GraphicsLayerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/scroll/ProgrammaticScrollAnimator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/LinkHighlight.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/web/LinkHighlight.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
A public/platform/WebAnimation.h View 1 chunk +82 lines, -0 lines 0 comments Download
A public/platform/WebAnimationCurve.h View 1 chunk +60 lines, -0 lines 0 comments Download
A public/platform/WebAnimationDelegate.h View 1 chunk +43 lines, -0 lines 0 comments Download
M public/platform/WebCompositorAnimation.h View 1 chunk +1 line, -37 lines 0 comments Download
M public/platform/WebCompositorAnimationCurve.h View 1 chunk +1 line, -27 lines 0 comments Download
M public/platform/WebCompositorAnimationDelegate.h View 1 chunk +2 lines, -16 lines 0 comments Download
M public/platform/WebCompositorSupport.h View 3 chunks +4 lines, -4 lines 0 comments Download
M public/platform/WebFilterAnimationCurve.h View 2 chunks +2 lines, -2 lines 0 comments Download
M public/platform/WebFloatAnimationCurve.h View 2 chunks +2 lines, -2 lines 0 comments Download
M public/platform/WebLayer.h View 3 chunks +5 lines, -5 lines 0 comments Download
M public/platform/WebScrollOffsetAnimationCurve.h View 1 chunk +2 lines, -2 lines 0 comments Download
M public/platform/WebTransformAnimationCurve.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
samli
Created Revert of Rename WebAnimation to WebCompositorAnimation
6 years, 4 months ago (2014-08-13 01:49:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samli@chromium.org/470443002/1
6 years, 4 months ago (2014-08-13 01:51:50 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 01:51:50 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-13 01:51:51 UTC) #4
alancutter (OOO until 2018)
The CQ bit was checked by alancutter@chromium.org
6 years, 4 months ago (2014-08-13 02:02:30 UTC) #5
alancutter (OOO until 2018)
lgtm
6 years, 4 months ago (2014-08-13 02:02:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samli@chromium.org/470443002/1
6 years, 4 months ago (2014-08-13 02:03:45 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 02:04:30 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 02:04:31 UTC) #9
Failed to apply patch for Source/web/LinkHighlight.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/web/LinkHighlight.h
  Hunk #2 FAILED at 49.
  Hunk #3 FAILED at 63.
  2 out of 3 hunks FAILED -- saving rejects to file
Source/web/LinkHighlight.h.rej

Patch:       Source/web/LinkHighlight.h
Index: Source/web/LinkHighlight.h
diff --git a/Source/web/LinkHighlight.h b/Source/web/LinkHighlight.h
index
274e6aecafff712d537bdd412c5d87e383837ff9..5fa89dcef8c942201401bbefb47921324d4ea586
100644
--- a/Source/web/LinkHighlight.h
+++ b/Source/web/LinkHighlight.h
@@ -30,7 +30,7 @@
 #include "platform/geometry/IntPoint.h"
 #include "platform/graphics/GraphicsLayer.h"
 #include "platform/graphics/Path.h"
-#include "public/platform/WebCompositorAnimationDelegate.h"
+#include "public/platform/WebAnimationDelegate.h"
 #include "public/platform/WebContentLayer.h"
 #include "public/platform/WebContentLayerClient.h"
 #include "public/platform/WebLayer.h"
@@ -49,7 +49,7 @@
 struct WebRect;
 class WebViewImpl;
 
-class LinkHighlight FINAL : public WebContentLayerClient, public
WebCompositorAnimationDelegate, blink::LinkHighlightClient {
+class LinkHighlight FINAL : public WebContentLayerClient, public
WebAnimationDelegate, blink::LinkHighlightClient {
 public:
     static PassOwnPtr<LinkHighlight> create(blink::Node*, WebViewImpl*);
     virtual ~LinkHighlight();
@@ -63,9 +63,9 @@
     virtual void paintContents(WebCanvas*, const WebRect& clipRect, bool
canPaintLCDText, WebFloatRect& opaque,
         WebContentLayerClient::GraphicsContextStatus = GraphicsContextEnabled)
OVERRIDE;
 
-    // WebCompositorAnimationDelegate implementation.
-    virtual void notifyAnimationStarted(double monotonicTime,
blink::WebCompositorAnimation::TargetProperty) OVERRIDE;
-    virtual void notifyAnimationFinished(double monotonicTime,
blink::WebCompositorAnimation::TargetProperty) OVERRIDE;
+    // WebAnimationDelegate implementation.
+    virtual void notifyAnimationStarted(double monotonicTime,
blink::WebAnimation::TargetProperty) OVERRIDE;
+    virtual void notifyAnimationFinished(double monotonicTime,
blink::WebAnimation::TargetProperty) OVERRIDE;
 
     // LinkHighlightClient inplementation.
     virtual void invalidate() OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698