Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: Source/bindings/scripts/v8_dictionary.py

Issue 470063003: IDL: Use IdlArrayOrSequenceType for array/sequence IDL types (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-extend-IdlTypeBase
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/v8_dictionary.py
diff --git a/Source/bindings/scripts/v8_dictionary.py b/Source/bindings/scripts/v8_dictionary.py
index 3937b3f7076a68652037790c5d70b73e8d2124af..e6b9030531de472cea422872080919ba65df0614 100644
--- a/Source/bindings/scripts/v8_dictionary.py
+++ b/Source/bindings/scripts/v8_dictionary.py
@@ -83,7 +83,8 @@ def member_context(member):
'name': member.name,
'setter_name': setter_name_for_dictionary_member(member),
'v8_default_value': v8_default_value,
- 'v8_type': v8_types.v8_type(idl_type.base_type),
+ 'v8_type': (v8_types.v8_type(idl_type.base_type)
Nils Barth (inactive) 2014/08/14 14:24:44 Now, if this were a property on IdlType(Base) ...
+ if idl_type.is_interface_type else None),
haraken 2014/08/14 14:48:58 Just help me understand: Why do we want to set Non
Jens Widell 2014/08/14 15:02:55 The very useful v8_types.v8_type() function takes
Jens Widell 2014/08/14 15:22:03 Actually, this 'v8_type' doesn't appear to be used
Nils Barth (inactive) 2014/08/14 16:18:55 v8_type() is a Perl legacy; I kept it around as "m
}

Powered by Google App Engine
This is Rietveld 408576698