IDL: Use IdlArrayOrSequenceType for array/sequence IDL types

Source/bindings/scripts/v8_dictionary.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generate template contexts of dictionaries for both v8 bindings and
 implementation classes that are used by blink's core/modules.
 """
 
 import copy
 import operator
@@ skipping 65 matching lines @@
         'cpp_default_value': cpp_default_value,
         'cpp_type': idl_type.cpp_type,
         'cpp_value_to_v8_value': idl_type.cpp_value_to_v8_value(
             cpp_value='impl->%s()' % member.name, isolate='isolate',
             creation_context='creationContext',
             extended_attributes=member.extended_attributes),
         'has_method_name': has_method_name_for_dictionary_member(member),
         'name': member.name,
         'setter_name': setter_name_for_dictionary_member(member),
         'v8_default_value': v8_default_value,
-        'v8_type': v8_types.v8_type(idl_type.base_type),
+        'v8_type': (v8_types.v8_type(idl_type.base_type)

[Nils Barth (inactive), 2014/08/14 14:24:44]

Now, if this were a property on IdlType(Base) ... ;)

+                    if idl_type.is_interface_type else None),

[haraken, 2014/08/14 14:48:58]

Just help me understand: Why do we want to set None for types where
idl_type.is_interface_type is false?

[Jens Widell, 2014/08/14 15:02:55]

The very useful v8_types.v8_type() function takes an "interface name" and
prepends 'V8'. So it seemed appropriate to assume it was only relevant for
interface types.

Maybe it's poorly named?

[Jens Widell, 2014/08/14 15:22:03]

Actually, this 'v8_type' doesn't appear to be used at all, at least not
currently.

The 'v8_type' set by attribute_context() is used in one place in the
attributes.cpp template, and that use could be replaced with
"V8{{attribute.idl_type}}" if I'm not mistaken.

That leaves the 'v8_type' set by the code handling [SetWrapperReferenceTo], and
it uses IdlType.name, not IdlType.base_type. And all uses in .idl files refer to
interface types.

[Nils Barth (inactive), 2014/08/14 16:18:55]

v8_type() is a Perl legacy;
I kept it around as "mostly harmless",
but since it can be replaced by templates
(and we have "V8" hardcoded throughout templates),
we should kill it.

I think the reasoning was to encapsulate the "V8" prefix,
perhaps by analogy with other targets (JSC?),
but this was never done consistently, it's too heavy-weight anyway,
and a simple sed on /V8/ works pretty well ;)

Thanks for the investigation!

     }
 
 
 # Context for implementation classes
 
 def dictionary_impl_context(dictionary, interfaces_info):
     includes.clear()
     header_includes = set(['platform/heap/Handle.h'])
     return {
         'header_includes': header_includes,
@@ skipping 30 matching lines @@
         'getter_expression': getter_expression(),
         'has_method_expression': has_method_expression(),
         'has_method_name': has_method_name_for_dictionary_member(member),
         'is_traceable': (idl_type.is_garbage_collected or
                          idl_type.is_will_be_garbage_collected),
         'member_cpp_type': member_cpp_type(),
         'name': member.name,
         'rvalue_cpp_type': idl_type.cpp_type_args(used_as_rvalue_type=True),
         'setter_name': setter_name_for_dictionary_member(member),
     }