Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: Source/bindings/scripts/v8_methods.py

Issue 470063003: IDL: Use IdlArrayOrSequenceType for array/sequence IDL types (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-extend-IdlTypeBase
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/v8_methods.py
diff --git a/Source/bindings/scripts/v8_methods.py b/Source/bindings/scripts/v8_methods.py
index 5f639d154f82c1dbb438bcdbbb8a8f4f6a59283b..53b4d353f52de89cae9527856f629d310c055461 100644
--- a/Source/bindings/scripts/v8_methods.py
+++ b/Source/bindings/scripts/v8_methods.py
@@ -53,7 +53,7 @@ CUSTOM_REGISTRATION_EXTENDED_ATTRIBUTES = frozenset([
def argument_needs_try_catch(argument, return_promise):
idl_type = argument.idl_type
- base_type = not idl_type.native_array_element_type and idl_type.base_type
+ base_type = idl_type.base_type
return not (
# These cases are handled by separate code paths in the
@@ -233,7 +233,7 @@ def argument_context(interface, method, argument, index):
has_extended_attribute_value(method, 'TypeChecking', 'Unrestricted')) and
idl_type.name in ('Float', 'Double'),
# Dictionary is special-cased, but arrays and sequences shouldn't be
- 'idl_type': not idl_type.native_array_element_type and idl_type.base_type,
+ 'idl_type': idl_type.base_type,
'idl_type_object': idl_type,
'index': index,
'is_clamp': 'Clamp' in extended_attributes,

Powered by Google App Engine
This is Rietveld 408576698