Allow the grit GN targets to specify an output name.

Allow the grit GN targets to specify an output name.

This resolves collisions if two grit targets with the same name (often
"resources") end up in the same output directory.

This reverts 289283 and replaces it with the unique output names rather than
the duplicative target names. The original problem was from 289264.

BUG=
R=joaodasilva@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289691

[Joao da Silva, 2014-08-13 20:47:27]

lgtm

This is much better than forcing the BUILD.gn authors to use unique target
names. But it still requires specifying the "output_name" to avoid clashes and
author may inadvertently overlook that detail. WDYT of deriving an "output_name"
from the "output_dir" and the "source"? (possibly mangled since it may contain
directories)

https://codereview.chromium.org/469893002/diff/1/build/secondary/tools/grit/g...
File build/secondary/tools/grit/grit_rule.gni (right):

https://codereview.chromium.org/469893002/diff/1/build/secondary/tools/grit/g...
build/secondary/tools/grit/grit_rule.gni:258: # The config and the action below
get this visibility son only the generated
nit: son -> so

[Dirk Pranke, 2014-08-14 01:06:57]

> This is much better than forcing the BUILD.gn authors to use unique target
> names. But it still requires specifying the "output_name" to avoid clashes and
> author may inadvertently overlook that detail. WDYT of deriving an
"output_name"
> from the "output_dir" and the "source"? (possibly mangled since it may contain
> directories)

That seems kinda un-GN-like; I like being more explicit like this.

[brettw, 2014-08-14 19:30:59]

I also like being explicit. I think this should be a temporary measure since I
think that grit outputs should always go in the target directory. The only
reason not to is for GYP parity, so hopefully we can remove all of this in the
future.

[brettw, 2014-08-14 20:32:21]

Committed patchset #1 manually as 289691.