Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/BUILD.gn

Issue 469893002: Allow the grit GN targets to specify an output name. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/secondary/tools/grit/grit_rule.gni ('K') | « chrome/BUILD.gn ('k') | chrome/renderer/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/BUILD.gn
diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn
index 250ddbdf9b55ea99dc30e6206df9ad239a63ab95..c914632684b7e5792bd391e45cd459676b148247 100644
--- a/chrome/common/BUILD.gn
+++ b/chrome/common/BUILD.gn
@@ -12,9 +12,10 @@ gypi_values = exec_script(
# GYP version: chrome/chrome_resources.gyp:chrome_resources
# (generate_common_resources action)
-grit("common_resources") {
+grit("resources") {
source = "common_resources.grd"
output_dir = "$root_gen_dir/chrome"
+ output_name = "common_resources"
outputs = [
"grit/common_resources.h",
"common_resources.pak",
« build/secondary/tools/grit/grit_rule.gni ('K') | « chrome/BUILD.gn ('k') | chrome/renderer/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698