Allow the grit GN targets to specify an output name.

build/secondary/tools/grit/grit_rule.gni

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Instantiate grit. This will produce a script target to run grit, and a
 # static library that compiles the .cc files.
 #
 # Parameters
 #
 #   source (required)
@@ skipping 16 matching lines @@
 #           python tools/grit/grit_info.py --outputs . path/to/your.grd
 #       And strip the leading "./" from the output files.
 #
 #   defines (optional)
 #       Extra defines to pass to grit (on top of the global grit_defines list).
 #
 #   grit_flags (optional)
 #       List of strings containing extra command-line flags to pass to Grit.
 #
 #   resource_ids (optional)
-#     Path to a grit "firstidsfile". Default is
-#     //tools/gritsettings/resource_ids. Set to "" to use the value specified in
-#     the <grit> nodes of the processed files.
+#       Path to a grit "firstidsfile". Default is
+#       //tools/gritsettings/resource_ids. Set to "" to use the value specified
+#       in the <grit> nodes of the processed files.
 #
 #   output_dir (optional)
-#     Directory for generated files.
+#       Directory for generated files. If you specify this, you will often
+#       want to specify output_name if the target name is not particularly
+#       unique, since this can cause files from multiple grit targets to
+#       overwrite each other.
+#
+#   output_name (optiona)
+#       Provide an alternate base name for the generated files, like the .d
+#       files. Normally these are based on the target name and go in the
+#       output_dir, but if multiple targets with the same name end up in
+#       the same output_dir, they can collide.
 #
 #   use_qualified_include (optional)
-#     If set, output_dir is not added to include_dirs.
+#       If set, output_dir is not added to include_dirs.
 #
 #   deps  (optional)
 #   visibility  (optional)
 #       Normal meaning.
 #
 # Example
 #
 #   grit("my_resources") {
 #     # Source and outputs are required.
 #     source = "myfile.grd"
@@ skipping 144 matching lines @@
   } else {
     resource_ids = grit_resource_id_file
   }
 
   if (defined(invoker.output_dir)) {
     output_dir = invoker.output_dir
   } else {
     output_dir = target_gen_dir
   }
 
+  if (defined(invoker.output_name)) {
+    grit_output_name = invoker.output_name
+  } else {
+    grit_output_name = target_name
+  }
+
   # These are all passed as arguments to the script so have to be relative to
   # the build directory.
   if (resource_ids != "") {
     resource_ids = rebase_path(resource_ids, root_build_dir)
   }
   rebased_output_dir = rebase_path(output_dir, root_build_dir)
   source_path = rebase_path(invoker.source, root_build_dir)
 
   if (defined(invoker.grit_flags)) {
     grit_flags = invoker.grit_flags
   } else {
     grit_flags = []  # These are optional so default to empty list.
   }
 
   grit_inputs = [ invoker.source ]
 
   assert_files_flags = []
 
   # We want to make sure the declared outputs actually match what Grit is
   # writing. We write the list to a file (some of the output lists are long
   # enough to not fit on a Windows command line) and ask Grit to verify those
   # are the actual outputs at runtime.
-  asserted_list_file = "$target_out_dir/${target_name}_expected_outputs.txt"
+  asserted_list_file =
+      "$target_out_dir/${grit_output_name}_expected_outputs.txt"
   write_file(asserted_list_file,
              rebase_path(invoker.outputs, root_build_dir, output_dir))
   assert_files_flags += [
     "--assert-file-list=" + rebase_path(asserted_list_file, root_build_dir),
   ]
   grit_outputs = get_path_info(
       rebase_path(invoker.outputs, ".", output_dir),
       "abspath")
 
   # The config and the action below get this visibility son only the generated

[Joao da Silva, 2014/08/13 20:47:27]

nit: son -> so

   # source set can depend on them. The variable "target_name" will get
-  # overwritten inside the innter classes so we need to compute it here.
+  # overwritten inside the inner classes so we need to compute it here.
   target_visibility = ":$target_name"
 
   # The current grit setup makes an file in $output_dir/grit/foo.h that
   # the source code expects to include via "grit/foo.h". It would be nice to
   # change this to including absolute paths relative to the root gen directory
   # (like "mycomponent/foo.h"). This config sets up the include path.
   grit_config = target_name + "_grit_config"
   config(grit_config) {
     if (!defined(invoker.use_qualified_include) ||
         !invoker.use_qualified_include) {
       include_dirs = [ output_dir ]
     }
     visibility = target_visibility
   }
 
   grit_custom_target = target_name + "_grit"
   action(grit_custom_target) {
     script = "//tools/grit/grit.py"
     inputs = grit_inputs
     outputs = grit_outputs
-    depfile = "$output_dir/${target_name}.d"
+    depfile = "$output_dir/${grit_output_name}.d"
 
     args = [
       "-i", source_path, "build",
       "-f", resource_ids,
       "-o", rebased_output_dir,
       "--depdir", ".",
       "--depfile", rebase_path(depfile, root_build_dir),
     ] + grit_defines
 
     # Add extra defines with -D flags.
@@ skipping 21 matching lines @@
     sources = grit_outputs
 
     # Deps set on the template invocation will go on the grit script running
     # target rather than this library.
     deps = [ ":$grit_custom_target" ]
     direct_dependent_configs = [ ":$grit_config" ]
 
     if (defined(invoker.visibility)) {
       visibility = invoker.visibility
     }
-    if (defined(invoker.output_name)) {
-      output_name = invoker.output_name
-    }
+    output_name = grit_output_name
   }
 }