Issue 469483002: [Android] Route selection event updates to ContentViewClient

Issue 469483002: [Android] Route selection event updates to ContentViewClient (Closed)

Created:
6 years, 4 months ago by jdduke (slow)

Modified:
6 years, 4 months ago

Reviewers:
Ted C

CC:
chromium-reviews, darin-cc_chromium.org, jdduke+watch_chromium.org, jam, Donn Denman, pedro (no code reviews)

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Android] Route selection handle dragging updates to ContentViewClient Notify the ContentViewClient of selection and insertion-related events, allowing customized behavior depending on the state of selection. This is particularly relevant for informing how the selection text string is being updated. BUG=400824 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289193

Patch Set 1 #

Patch Set 2 : TODO #

Patch Set 3 : Cleanup #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -13 lines)			Patch
M	content/browser/renderer_host/input/selection_event_type_list.h	View		1 chunk	+7 lines, -5 lines	0 comments	Download
M	content/browser/renderer_host/input/touch_selection_controller.cc	View		3 chunks	+5 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/input/touch_selection_controller_unittest.cc	View		4 chunks	+4 lines, -0 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java	View	1 2	2 chunks	+13 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jdduke (slow)

tedchoc@: PTAL. It's unfortunate we're cluttering the ContentViewClient interface even more, but Donn said he'd ...

6 years, 4 months ago (2014-08-12 19:29:49 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/469483002/40001

6 years, 4 months ago (2014-08-12 22:54:59 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win ...

6 years, 4 months ago (2014-08-13 02:21:18 UTC) #5

Message was sent while issue was closed.

Change committed as 289193

Expand Messages | Collapse Messages