Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java

Issue 469483002: [Android] Route selection event updates to ContentViewClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
index 81825090adeb07caa1924cdc56684c2637a75c5e..c3e4bf091c5203b9174c50ce5585da6514d804eb 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
@@ -123,12 +123,21 @@ public class ContentViewClient {
/**
* Notification that the selection has changed.
+ * TODO(donnd): Remove this and instead expose a ContextualSearchClient, crbug.com/403001.
* @param selection The newly established selection.
*/
public void onSelectionChanged(String selection) {
}
/**
+ * Notification that a selection or insertion-related event has occurred.
+ * TODO(donnd): Remove this and instead expose a ContextualSearchClient, crbug.com/403001.
+ * @param eventType The selection event type, see {@link SelectionEventType}.
+ */
+ public void onSelectionEvent(int eventType) {
+ }
+
+ /**
* Called when a new content intent is requested to be started.
*/
public void onStartContentIntent(Context context, String intentUrl) {

Powered by Google App Engine
This is Rietveld 408576698