Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 469393004: Mojo: Add warning of invalid serialization results (in debug build). (Closed)

Created:
6 years, 4 months ago by yzshen1
Modified:
6 years, 4 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, hansmuller
Project:
chromium
Visibility:
Public.

Description

Mojo: Add warning of invalid serialization results (in debug build). A fatal-level message is logged if: - a fixed-size array has wrong number of elements; - a non-nullable field is set to null (or invalid handle). BUG=324170 TEST=SerializationWarningTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290487

Patch Set 1 #

Patch Set 2 : add tests #

Patch Set 3 : #

Patch Set 4 : cleanup #

Total comments: 4

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : fix java generator #

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+517 lines, -77 lines) Patch
M mojo/mojo_public_tests.gypi View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/array_internal.h View 1 2 3 4 5 8 chunks +11 lines, -11 lines 0 comments Download
M mojo/public/cpp/bindings/lib/array_serialization.h View 1 2 3 4 5 9 chunks +90 lines, -20 lines 0 comments Download
M mojo/public/cpp/bindings/lib/validation_errors.h View 2 chunks +37 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/validation_errors.cc View 2 chunks +23 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/array_unittest.cc View 1 2 3 4 16 chunks +37 lines, -19 lines 0 comments Download
A mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc View 1 2 3 4 5 6 7 8 1 chunk +210 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/struct_unittest.cc View 1 2 3 6 chunks +14 lines, -5 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/serialization_test_structs.mojom View 1 2 3 4 5 6 7 8 1 chunk +32 lines, -0 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/test_structs.mojom View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/Decoder.java View 1 2 3 4 5 6 7 2 chunks +8 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl View 1 1 chunk +24 lines, -9 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl View 1 2 3 1 chunk +21 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_cpp_generator.py View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
yzshen1
Hi, Darin. Would you please take a look? Thanks!
6 years, 4 months ago (2014-08-18 22:08:18 UTC) #1
darin (slow to review)
LGTM https://codereview.chromium.org/469393004/diff/60001/mojo/public/cpp/bindings/lib/array_serialization.h File mojo/public/cpp/bindings/lib/array_serialization.h (right): https://codereview.chromium.org/469393004/diff/60001/mojo/public/cpp/bindings/lib/array_serialization.h#newcode44 mojo/public/cpp/bindings/lib/array_serialization.h:44: template <bool element_nullable, typename ElementValidateParams> nit: element_is_nullable <- ...
6 years, 4 months ago (2014-08-18 22:14:14 UTC) #2
yzshen1
Thank you, Darin! https://codereview.chromium.org/469393004/diff/60001/mojo/public/cpp/bindings/lib/array_serialization.h File mojo/public/cpp/bindings/lib/array_serialization.h (right): https://codereview.chromium.org/469393004/diff/60001/mojo/public/cpp/bindings/lib/array_serialization.h#newcode44 mojo/public/cpp/bindings/lib/array_serialization.h:44: template <bool element_nullable, typename ElementValidateParams> On ...
6 years, 4 months ago (2014-08-18 22:26:23 UTC) #3
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 4 months ago (2014-08-18 22:33:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/469393004/120001
6 years, 4 months ago (2014-08-18 22:34:37 UTC) #5
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 4 months ago (2014-08-19 00:18:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/469393004/160001
6 years, 4 months ago (2014-08-19 00:20:16 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 04:28:43 UTC) #8
Message was sent while issue was closed. 
Committed patchset #9 (160001) as 290487

Powered by Google App Engine
This is Rietveld 408576698