Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Side by Side Diff: mojo/public/cpp/bindings/tests/struct_unittest.cc

Issue 469393004: Mojo: Add warning of invalid serialization results (in debug build). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/public/cpp/bindings/lib/fixed_buffer.h" 5 #include "mojo/public/cpp/bindings/lib/fixed_buffer.h"
6 #include "mojo/public/cpp/environment/environment.h"
6 #include "mojo/public/interfaces/bindings/tests/test_structs.mojom.h" 7 #include "mojo/public/interfaces/bindings/tests/test_structs.mojom.h"
7 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
8 9
9 namespace mojo { 10 namespace mojo {
10 namespace test { 11 namespace test {
11 namespace { 12 namespace {
12 13
13 RectPtr MakeRect(int32_t factor = 1) { 14 RectPtr MakeRect(int32_t factor = 1) {
14 RectPtr rect(Rect::New()); 15 RectPtr rect(Rect::New());
15 rect->x = 1 * factor; 16 rect->x = 1 * factor;
16 rect->y = 2 * factor; 17 rect->y = 2 * factor;
17 rect->width = 10 * factor; 18 rect->width = 10 * factor;
18 rect->height = 20 * factor; 19 rect->height = 20 * factor;
19 return rect.Pass(); 20 return rect.Pass();
20 } 21 }
21 22
22 void CheckRect(const Rect& rect, int32_t factor = 1) { 23 void CheckRect(const Rect& rect, int32_t factor = 1) {
23 EXPECT_EQ(1 * factor, rect.x); 24 EXPECT_EQ(1 * factor, rect.x);
24 EXPECT_EQ(2 * factor, rect.y); 25 EXPECT_EQ(2 * factor, rect.y);
25 EXPECT_EQ(10 * factor, rect.width); 26 EXPECT_EQ(10 * factor, rect.width);
26 EXPECT_EQ(20 * factor, rect.height); 27 EXPECT_EQ(20 * factor, rect.height);
27 } 28 }
28 29
30 class StructTest : public testing::Test {
31 public:
32 virtual ~StructTest() {}
33
34 private:
35 Environment env_;
36 };
37
29 } // namespace 38 } // namespace
30 39
31 TEST(StructTest, Rect) { 40 TEST_F(StructTest, Rect) {
32 RectPtr rect; 41 RectPtr rect;
33 EXPECT_TRUE(rect.is_null()); 42 EXPECT_TRUE(rect.is_null());
34 EXPECT_TRUE(!rect); 43 EXPECT_TRUE(!rect);
35 EXPECT_FALSE(rect); 44 EXPECT_FALSE(rect);
36 45
37 rect = MakeRect(); 46 rect = MakeRect();
38 EXPECT_FALSE(rect.is_null()); 47 EXPECT_FALSE(rect.is_null());
39 EXPECT_FALSE(!rect); 48 EXPECT_FALSE(!rect);
40 EXPECT_TRUE(rect); 49 EXPECT_TRUE(rect);
41 50
42 CheckRect(*rect); 51 CheckRect(*rect);
43 } 52 }
44 53
45 // Serialization test of a struct with no pointer or handle members. 54 // Serialization test of a struct with no pointer or handle members.
46 TEST(StructTest, Serialization_Basic) { 55 TEST_F(StructTest, Serialization_Basic) {
47 RectPtr rect(MakeRect()); 56 RectPtr rect(MakeRect());
48 57
49 size_t size = GetSerializedSize_(rect); 58 size_t size = GetSerializedSize_(rect);
50 EXPECT_EQ(8U + 16U, size); 59 EXPECT_EQ(8U + 16U, size);
51 60
52 mojo::internal::FixedBuffer buf(size); 61 mojo::internal::FixedBuffer buf(size);
53 internal::Rect_Data* data; 62 internal::Rect_Data* data;
54 Serialize_(rect.Pass(), &buf, &data); 63 Serialize_(rect.Pass(), &buf, &data);
55 64
56 RectPtr rect2; 65 RectPtr rect2;
57 Deserialize_(data, &rect2); 66 Deserialize_(data, &rect2);
58 67
59 CheckRect(*rect2); 68 CheckRect(*rect2);
60 } 69 }
61 70
62 // Serialization test of a struct with struct pointers. 71 // Serialization test of a struct with struct pointers.
63 TEST(StructTest, Serialization_StructPointers) { 72 TEST_F(StructTest, Serialization_StructPointers) {
64 RectPairPtr pair(RectPair::New()); 73 RectPairPtr pair(RectPair::New());
65 pair->first = MakeRect(); 74 pair->first = MakeRect();
66 pair->second = MakeRect(); 75 pair->second = MakeRect();
67 76
68 size_t size = GetSerializedSize_(pair); 77 size_t size = GetSerializedSize_(pair);
69 EXPECT_EQ(8U + 16U + 2*(8U + 16U), size); 78 EXPECT_EQ(8U + 16U + 2*(8U + 16U), size);
70 79
71 mojo::internal::FixedBuffer buf(size); 80 mojo::internal::FixedBuffer buf(size);
72 internal::RectPair_Data* data; 81 internal::RectPair_Data* data;
73 Serialize_(pair.Pass(), &buf, &data); 82 Serialize_(pair.Pass(), &buf, &data);
74 83
75 RectPairPtr pair2; 84 RectPairPtr pair2;
76 Deserialize_(data, &pair2); 85 Deserialize_(data, &pair2);
77 86
78 CheckRect(*pair2->first); 87 CheckRect(*pair2->first);
79 CheckRect(*pair2->second); 88 CheckRect(*pair2->second);
80 } 89 }
81 90
82 // Serialization test of a struct with an array member. 91 // Serialization test of a struct with an array member.
83 TEST(StructTest, Serialization_ArrayPointers) { 92 TEST_F(StructTest, Serialization_ArrayPointers) {
84 NamedRegionPtr region(NamedRegion::New()); 93 NamedRegionPtr region(NamedRegion::New());
85 region->name = "region"; 94 region->name = "region";
86 region->rects = Array<RectPtr>::New(4); 95 region->rects = Array<RectPtr>::New(4);
87 for (size_t i = 0; i < region->rects.size(); ++i) 96 for (size_t i = 0; i < region->rects.size(); ++i)
88 region->rects[i] = MakeRect(static_cast<int32_t>(i) + 1); 97 region->rects[i] = MakeRect(static_cast<int32_t>(i) + 1);
89 98
90 size_t size = GetSerializedSize_(region); 99 size_t size = GetSerializedSize_(region);
91 EXPECT_EQ(8U + // header 100 EXPECT_EQ(8U + // header
92 8U + // name pointer 101 8U + // name pointer
93 8U + // rects pointer 102 8U + // rects pointer
(...skipping 13 matching lines...) Expand all
107 Deserialize_(data, &region2); 116 Deserialize_(data, &region2);
108 117
109 EXPECT_EQ(String("region"), region2->name); 118 EXPECT_EQ(String("region"), region2->name);
110 119
111 EXPECT_EQ(4U, region2->rects.size()); 120 EXPECT_EQ(4U, region2->rects.size());
112 for (size_t i = 0; i < region2->rects.size(); ++i) 121 for (size_t i = 0; i < region2->rects.size(); ++i)
113 CheckRect(*region2->rects[i], static_cast<int32_t>(i) + 1); 122 CheckRect(*region2->rects[i], static_cast<int32_t>(i) + 1);
114 } 123 }
115 124
116 // Serialization test of a struct with null array pointers. 125 // Serialization test of a struct with null array pointers.
117 TEST(StructTest, Serialization_NullArrayPointers) { 126 TEST_F(StructTest, Serialization_NullArrayPointers) {
118 NamedRegionPtr region(NamedRegion::New()); 127 NamedRegionPtr region(NamedRegion::New());
119 EXPECT_TRUE(region->name.is_null()); 128 EXPECT_TRUE(region->name.is_null());
120 EXPECT_TRUE(region->rects.is_null()); 129 EXPECT_TRUE(region->rects.is_null());
121 130
122 size_t size = GetSerializedSize_(region); 131 size_t size = GetSerializedSize_(region);
123 EXPECT_EQ(8U + // header 132 EXPECT_EQ(8U + // header
124 8U + // name pointer 133 8U + // name pointer
125 8U, // rects pointer 134 8U, // rects pointer
126 size); 135 size);
127 136
128 mojo::internal::FixedBuffer buf(size); 137 mojo::internal::FixedBuffer buf(size);
129 internal::NamedRegion_Data* data; 138 internal::NamedRegion_Data* data;
130 Serialize_(region.Pass(), &buf, &data); 139 Serialize_(region.Pass(), &buf, &data);
131 140
132 NamedRegionPtr region2; 141 NamedRegionPtr region2;
133 Deserialize_(data, &region2); 142 Deserialize_(data, &region2);
134 143
135 EXPECT_TRUE(region2->name.is_null()); 144 EXPECT_TRUE(region2->name.is_null());
136 EXPECT_TRUE(region2->rects.is_null()); 145 EXPECT_TRUE(region2->rects.is_null());
137 } 146 }
138 147
139 } // namespace test 148 } // namespace test
140 } // namespace mojo 149 } // namespace mojo
OLDNEW
« no previous file with comments | « mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc ('k') | mojo/public/interfaces/bindings/tests/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698