Mojo: Add warning of invalid serialization results (in debug build).

mojo/public/cpp/bindings/tests/array_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/public/cpp/bindings/array.h"
+#include "mojo/public/cpp/bindings/lib/array_internal.h"
 #include "mojo/public/cpp/bindings/lib/array_serialization.h"
 #include "mojo/public/cpp/bindings/lib/fixed_buffer.h"
 #include "mojo/public/cpp/environment/environment.h"
-#include "mojo/public/interfaces/bindings/tests/sample_service.mojom.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace mojo {
 namespace test {
 namespace {
 
 class CopyableType {
  public:
   CopyableType() : copied_(false), ptr_(this) { num_instances_++; }
   CopyableType(const CopyableType& other) : copied_(true), ptr_(other.ptr()) {
@@ skipping 40 matching lines @@
   void ResetMoved() { moved_ = false; }
 
  private:
   bool moved_;
   static size_t num_instances_;
   MoveOnlyType* ptr_;
 };
 
 size_t MoveOnlyType::num_instances_ = 0;
 
+class ArrayTest : public testing::Test {
+ public:
+  virtual ~ArrayTest() {}
+
+ private:
+  Environment env_;
+};
+
 // Tests that basic Array operations work.
-TEST(ArrayTest, Basic) {
+TEST_F(ArrayTest, Basic) {
   Array<char> array(8);
   for (size_t i = 0; i < array.size(); ++i) {
     char val = static_cast<char>(i*2);
     array[i] = val;
     EXPECT_EQ(val, array.at(i));
   }
 }
 
 // Tests that basic Array<bool> operations work.
-TEST(ArrayTest, Bool) {
+TEST_F(ArrayTest, Bool) {
   Array<bool> array(64);
   for (size_t i = 0; i < array.size(); ++i) {
     bool val = i % 3 == 0;
     array[i] = val;
     EXPECT_EQ(val, array.at(i));
   }
 }
 
 // Tests that Array<ScopedMessagePipeHandle> supports transferring handles.
-TEST(ArrayTest, Handle) {
+TEST_F(ArrayTest, Handle) {
   MessagePipe pipe;
   Array<ScopedMessagePipeHandle> handles(2);
   handles[0] = pipe.handle0.Pass();
   handles[1].reset(pipe.handle1.release());
 
   EXPECT_FALSE(pipe.handle0.is_valid());
   EXPECT_FALSE(pipe.handle1.is_valid());
 
   Array<ScopedMessagePipeHandle> handles2 = handles.Pass();
   EXPECT_TRUE(handles2[0].is_valid());
   EXPECT_TRUE(handles2[1].is_valid());
 
   ScopedMessagePipeHandle pipe_handle = handles2[0].Pass();
   EXPECT_TRUE(pipe_handle.is_valid());
   EXPECT_FALSE(handles2[0].is_valid());
 }
 
 // Tests that Array<ScopedMessagePipeHandle> supports closing handles.
-TEST(ArrayTest, HandlesAreClosed) {
+TEST_F(ArrayTest, HandlesAreClosed) {
   MessagePipe pipe;
   MojoHandle pipe0_value = pipe.handle0.get().value();
   MojoHandle pipe1_value = pipe.handle0.get().value();
 
   {
     Array<ScopedMessagePipeHandle> handles(2);
     handles[0] = pipe.handle0.Pass();
     handles[1].reset(pipe.handle0.release());
   }
 
   // We expect the pipes to have been closed.
   EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, MojoClose(pipe0_value));
   EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, MojoClose(pipe1_value));
 }
 
-TEST(ArrayTest, Serialization_ArrayOfPOD) {
+TEST_F(ArrayTest, Serialization_ArrayOfPOD) {
   Array<int32_t> array(4);
   for (size_t i = 0; i < array.size(); ++i)
     array[i] = static_cast<int32_t>(i);
 
   size_t size = GetSerializedSize_(array);
   EXPECT_EQ(8U + 4*4U, size);
 
   internal::FixedBuffer buf(size);
   internal::Array_Data<int32_t>* data;
-  Serialize_(array.Pass(), &buf, &data);
+  SerializeArray_<internal::ArrayValidateParams<0, false,
+                  internal::NoValidateParams> >(
+      array.Pass(), &buf, &data);
 
   Array<int32_t> array2;
   Deserialize_(data, &array2);
 
   EXPECT_EQ(4U, array2.size());
   for (size_t i = 0; i < array2.size(); ++i)
     EXPECT_EQ(static_cast<int32_t>(i), array2[i]);
 }
 
-TEST(ArrayTest, Serialization_ArrayOfArrayOfPOD) {
+TEST_F(ArrayTest, Serialization_ArrayOfArrayOfPOD) {
   Array<Array<int32_t> > array(2);
   for (size_t j = 0; j < array.size(); ++j) {
     Array<int32_t> inner(4);
     for (size_t i = 0; i < inner.size(); ++i)
       inner[i] = static_cast<int32_t>(i + (j * 10));
     array[j] = inner.Pass();
   }
 
   size_t size = GetSerializedSize_(array);
   EXPECT_EQ(8U + 2*8U + 2*(8U + 4*4U), size);
 
   internal::FixedBuffer buf(size);
   internal::Array_Data<internal::Array_Data<int32_t>*>* data;
-  Serialize_(array.Pass(), &buf, &data);
+  SerializeArray_<internal::ArrayValidateParams<0, false,
+                  internal::ArrayValidateParams<0, false,
+                  internal::NoValidateParams> > >(
+      array.Pass(), &buf, &data);
 
   Array<Array<int32_t> > array2;
   Deserialize_(data, &array2);
 
   EXPECT_EQ(2U, array2.size());
   for (size_t j = 0; j < array2.size(); ++j) {
     const Array<int32_t>& inner = array2[j];
     EXPECT_EQ(4U, inner.size());
     for (size_t i = 0; i < inner.size(); ++i)
       EXPECT_EQ(static_cast<int32_t>(i + (j * 10)), inner[i]);
   }
 }
 
-TEST(ArrayTest, Serialization_ArrayOfBool) {
+TEST_F(ArrayTest, Serialization_ArrayOfBool) {
   Array<bool> array(10);
   for (size_t i = 0; i < array.size(); ++i)
     array[i] = i % 2 ? true : false;
 
   size_t size = GetSerializedSize_(array);
   EXPECT_EQ(8U + 8U, size);
 
   internal::FixedBuffer buf(size);
   internal::Array_Data<bool>* data;
-  Serialize_(array.Pass(), &buf, &data);
+  SerializeArray_<internal::ArrayValidateParams<0, false,
+                  internal::NoValidateParams> >(
+      array.Pass(), &buf, &data);
 
   Array<bool> array2;
   Deserialize_(data, &array2);
 
   EXPECT_EQ(10U, array2.size());
   for (size_t i = 0; i < array2.size(); ++i)
     EXPECT_EQ(i % 2 ? true : false, array2[i]);
 }
 
-TEST(ArrayTest, Serialization_ArrayOfString) {
+TEST_F(ArrayTest, Serialization_ArrayOfString) {
   Array<String> array(10);
   for (size_t i = 0; i < array.size(); ++i) {
-    char c = 'A' + 1;
+    char c = 'A' + static_cast<char>(i);
     array[i] = String(&c, 1);
   }
 
   size_t size = GetSerializedSize_(array);
   EXPECT_EQ(8U +     // array header
             10*8U +  // array payload (10 pointers)
             10*(8U +  // string header
                 8U),  // string length of 1 padded to 8
             size);
 
   internal::FixedBuffer buf(size);
   internal::Array_Data<internal::String_Data*>* data;
-  Serialize_(array.Pass(), &buf, &data);
+  SerializeArray_<internal::ArrayValidateParams<0, false,
+                  internal::ArrayValidateParams<0, false,
+                  internal::NoValidateParams> > >(
+      array.Pass(), &buf, &data);
 
   Array<String> array2;
   Deserialize_(data, &array2);
 
   EXPECT_EQ(10U, array2.size());
   for (size_t i = 0; i < array2.size(); ++i) {
-    char c = 'A' + 1;
+    char c = 'A' + static_cast<char>(i);
     EXPECT_EQ(String(&c, 1), array2[i]);
   }
 }
 
-TEST(ArrayTest, Resize_Copyable) {
+TEST_F(ArrayTest, Resize_Copyable) {
   ASSERT_EQ(0u, CopyableType::num_instances());
   mojo::Array<CopyableType> array(3);
   std::vector<CopyableType*> value_ptrs;
   value_ptrs.push_back(array[0].ptr());
   value_ptrs.push_back(array[1].ptr());
 
   for (size_t i = 0; i < array.size(); i++)
     array[i].ResetCopied();
 
   array.resize(2);
@@ skipping 31 matching lines @@
     EXPECT_EQ(value_ptrs[i], array[i].ptr());
   }
   array.reset();
   EXPECT_EQ(0u, CopyableType::num_instances());
   EXPECT_FALSE(array);
   array.resize(0);
   EXPECT_EQ(0u, CopyableType::num_instances());
   EXPECT_TRUE(array);
 }
 
-TEST(ArrayTest, Resize_MoveOnly) {
+TEST_F(ArrayTest, Resize_MoveOnly) {
   ASSERT_EQ(0u, MoveOnlyType::num_instances());
   mojo::Array<MoveOnlyType> array(3);
   std::vector<MoveOnlyType*> value_ptrs;
   value_ptrs.push_back(array[0].ptr());
   value_ptrs.push_back(array[1].ptr());
 
   for (size_t i = 0; i < array.size(); i++)
     EXPECT_FALSE(array[i].moved());
 
   array.resize(2);
@@ skipping 31 matching lines @@
     EXPECT_FALSE(array[i].moved());
 
   array.reset();
   EXPECT_EQ(0u, MoveOnlyType::num_instances());
   EXPECT_FALSE(array);
   array.resize(0);
   EXPECT_EQ(0u, MoveOnlyType::num_instances());
   EXPECT_TRUE(array);
 }
 
-TEST(ArrayTest, PushBack_Copyable) {
+TEST_F(ArrayTest, PushBack_Copyable) {
   ASSERT_EQ(0u, CopyableType::num_instances());
   mojo::Array<CopyableType> array(2);
   array.reset();
   std::vector<CopyableType*> value_ptrs;
   size_t capacity = array.storage().capacity();
   for (size_t i = 0; i < capacity; i++) {
     CopyableType value;
     value_ptrs.push_back(value.ptr());
     array.push_back(value);
     ASSERT_EQ(i + 1, array.size());
@@ skipping 14 matching lines @@
   EXPECT_EQ(array.size(), CopyableType::num_instances());
 
   for (size_t i = 0; i < array.size(); i++) {
     EXPECT_TRUE(array[i].copied());
     EXPECT_EQ(value_ptrs[i], array[i].ptr());
   }
   array.reset();
   EXPECT_EQ(0u, CopyableType::num_instances());
 }
 
-TEST(ArrayTest, PushBack_MoveOnly) {
+TEST_F(ArrayTest, PushBack_MoveOnly) {
   ASSERT_EQ(0u, MoveOnlyType::num_instances());
   mojo::Array<MoveOnlyType> array(2);
   array.reset();
   std::vector<MoveOnlyType*> value_ptrs;
   size_t capacity = array.storage().capacity();
   for (size_t i = 0; i < capacity; i++) {
     MoveOnlyType value;
     value_ptrs.push_back(value.ptr());
     array.push_back(value.Pass());
     ASSERT_EQ(i + 1, array.size());
@@ skipping 17 matching lines @@
     EXPECT_TRUE(array[i].moved());
     EXPECT_EQ(value_ptrs[i], array[i].ptr());
   }
   array.reset();
   EXPECT_EQ(0u, MoveOnlyType::num_instances());
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace mojo