Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 469243002: IDL: Prefer to extend IdlTypeBase instead of IdlType (Closed)

Created:
6 years, 4 months ago by Jens Widell
Modified:
6 years, 4 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

IDL: Prefer to extend IdlTypeBase instead of IdlType In v8_types.py and elsewhere, we extend the classes defined in idl_types.py by adding properties or methods. Usually, these properties or methods are supposed to be available on all type objects. Since all type objects now have a common base class, IdlTypeBase, prefer to set new properties and methods on it instead of on IdlType. This doesn't change CG, and is done to simplify the process of adding new IdlTypeBase sub-classes in the future. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180276

Patch Set 1 #

Total comments: 2

Patch Set 2 : drop import of IdlType #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -30 lines) Patch
M Source/bindings/scripts/v8_callback_interface.py View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/scripts/v8_methods.py View 1 2 chunks +4 lines, -3 lines 0 comments Download
M Source/bindings/scripts/v8_types.py View 15 chunks +19 lines, -21 lines 0 comments Download
M Source/bindings/scripts/v8_utilities.py View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Jens Widell
PTAL I started implementing array/sequence types using a nested type (IdlArrayOrSequenceType) instead of a flag ...
6 years, 4 months ago (2014-08-14 10:35:50 UTC) #1
haraken
LGTM
6 years, 4 months ago (2014-08-14 10:50:02 UTC) #2
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 4 months ago (2014-08-14 10:55:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/469243002/1
6 years, 4 months ago (2014-08-14 10:56:54 UTC) #4
Nils Barth (inactive)
The CQ bit was unchecked by nbarth@chromium.org
6 years, 4 months ago (2014-08-14 13:50:56 UTC) #5
Nils Barth (inactive)
LGTM (with one nit) Thanks, this cleanup is long-desired! One nit (unused import), otherwise fine! ...
6 years, 4 months ago (2014-08-14 13:55:00 UTC) #6
Jens Widell
https://codereview.chromium.org/469243002/diff/1/Source/bindings/scripts/v8_methods.py File Source/bindings/scripts/v8_methods.py (right): https://codereview.chromium.org/469243002/diff/1/Source/bindings/scripts/v8_methods.py#newcode37 Source/bindings/scripts/v8_methods.py:37: from idl_types import IdlTypeBase, IdlType, IdlUnionType, inherits_interface On 2014/08/14 ...
6 years, 4 months ago (2014-08-14 13:59:21 UTC) #7
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 4 months ago (2014-08-14 14:00:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/469243002/20001
6 years, 4 months ago (2014-08-14 14:01:05 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 15:56:06 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180276

Powered by Google App Engine
This is Rietveld 408576698