Source/bindings/scripts/v8_callback_interface.py - Issue 469243002: IDL: Prefer to extend IdlTypeBase instead of IdlType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_callback_interface.py

Issue 469243002: IDL: Prefer to extend IdlTypeBase instead of IdlType (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: drop import of IdlType Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_callback_interface.py

diff --git a/Source/bindings/scripts/v8_callback_interface.py b/Source/bindings/scripts/v8_callback_interface.py

index 58233bcc77d7fa1a2e45204d11586e1cb6b5e3be..8ceeb9a7a8282bec7e67539bf8bb8aa5af7a14ac 100644

--- a/Source/bindings/scripts/v8_callback_interface.py

+++ b/Source/bindings/scripts/v8_callback_interface.py

@@ -28,12 +28,12 @@

"""Generate template values for a callback interface.

-Extends IdlType with property |callback_cpp_type|.

+Extends IdlTypeBase with property |callback_cpp_type|.

Design doc: http://www.chromium.org/developers/design-documents/idl-compiler

"""

-from idl_types import IdlType

+from idl_types import IdlTypeBase

from v8_globals import includes

import v8_types

import v8_utilities

@@ -67,7 +67,7 @@ def cpp_type(idl_type):

return 'const %s&' % raw_cpp_type

return raw_cpp_type

-IdlType.callback_cpp_type = property(cpp_type)

+IdlTypeBase.callback_cpp_type = property(cpp_type)

def callback_interface_context(callback_interface):

« no previous file with comments | « no previous file | Source/bindings/scripts/v8_methods.py » ('j') | no next file with comments »